Bring target specs in line with upstream #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make future diffs more readable, sort all keys in json target spec-files alphabetically. No changes to the content in this commit. Signed-off-by: Rahix <rahix@rahix.de>
Signed-off-by: Rahix <rahix@rahix.de>
Signed-off-by: Rahix <rahix@rahix.de>
`target-env` and `target-vendor` are now `env` and `vendor` respectively. Signed-off-by: Rahix <rahix@rahix.de>
Both options have the same value by default, let's not re-specify them in each target file. Signed-off-by: Rahix <rahix@rahix.de>
AVR targets do not have native CAS operations but the `atomic-cas` target option defaults to true. Explicitly set it to false. Signed-off-by: Rahix <rahix@rahix.de>
Actually, rustc adds `-Wl,--gc-sections` by itself already so this part is redundant. Signed-off-by: Rahix <rahix@rahix.de>
Bring out target specs closer to upstream by using the same linker options in the target spec files. Signed-off-by: Rahix <rahix@rahix.de>
Fixup the remaining little bits so the sync-script generates the exact same targets we currently use. Signed-off-by: Rahix <rahix@rahix.de>
|
CI's happy :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@explicite, I've reviewed all the changes which upstream did since I initially created these target files. I have carefully done each change as a separate commit so it is possible to retrace what happened. As far as I can tell, this does not produce any regressions in avr-hal, but let's see what CI has to say about this.
Finally fixes #32.