Fixes for pro micro #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forked at: 9ae4ef9 Parent branch: Rahix/master
|
(I'm not sure if the failing example is valid on the pro micro. It seems it lacks the necessary pins) |
If the pro micro has an onboard LED you should use that pin instead. If not, any pin you like will do ... |
|
Can you do this change so I can merge the PR? :) |
|
@Rahix can you check and let me know if the pin I chose make sense? |
Rahix
approved these changes
Oct 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is no pin but there is still ACD1 and ACD0 on the schematics. Does that mean it still have a use? (For the alternate function --
I'm not sure what's the alternate functionok I think I know--) Then, should we keep them anyway?