Дюкин Петр, ts-1 #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Toouren
reviewed
Apr 4, 2021
| stringsArrayProp: string[], | ||
| numbersOrDatesArrayProp: Array<number | Date>, | ||
| functionProp: Function | ||
| }; | ||
|
|
Toouren
reviewed
Apr 4, 2021
| array.forEach(item => { | ||
| if (typeof item === type) res.push(item) | ||
| }); | ||
| return res; | ||
| } |
There was a problem hiding this comment.
Работать не будет, т.к. в рантайме у x будет тип Object => ни один объект не попадет результирующий массив
Toouren
reviewed
Apr 4, 2021
| function add(x: number, y: number): number; | ||
| function add(x: string | number, y: string | number): string | number { | ||
| return typeof x === "string" ? <string>x + <string>y : <number>x + <number>y; | ||
| } | ||
|
|
Toouren
reviewed
Apr 4, 2021
| * мое понимание в их различии стало именно таким. Думаю, что нет смысла копировать и переводить | ||
| * материал оттуда, да и врать, что взял все это из головы - тоже..) | ||
| * В любом случае извините...) | ||
| */ |
Toouren
reviewed
Apr 4, 2021
| @@ -73,7 +74,7 @@ export function logPerson(person: Person) { | |||
| console.log(` - ${person.name}, ${person.age}, ${additionalInformation}`); | |||
| } | |||
|
|
|||
| export function filterUsers(persons: Person[], criteria: User): User[] { | |||
| export function filterUsers(persons: Person[], criteria: HybridUser): User[] { | |||
| return persons.filter(isUser).filter((user) => { | |||
| const criteriaKeys = Object.keys(criteria); | |||
| return criteriaKeys.every((fieldName) => { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.