Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable igemmlt int test on rocm #3

Merged
merged 15 commits into from
Jan 17, 2024

Conversation

pnunna93
Copy link
Collaborator

This PR has changes to enable igemmlt function and its dependencies.

  • Updated igemmlt function to use row to col transformation in HIP environment
  • Updated nvidia_transform function for row to col and col to row transformations
  • transform function calls routed to nvidia_transform for HIP
  • Updated output buffer allocations for col format

@pnunna93
Copy link
Collaborator Author

These are the test statistics before and after this PR:

Before igemmlt:

Module Passed Failed Skipped
functional 261 34 73
autograd 680 24 1536
linear8bitlt 2 0 16
modules 10 3 1
optim 125 26 26
triton 0 0 2
Total 1078 87 1654

After igemmlt:

Module Passed Failed Skipped
functional 286 23 27
autograd 1592 648 0
linear8bitlt 9 9 0
modules 10 4 0
optim 125 26 26
triton 0 0 2
Total 2022 710 55

@Lzy17
Copy link

Lzy17 commented Jan 17, 2024

looks good to me!

Copy link
Collaborator

@amathews-amd amathews-amd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amathews-amd amathews-amd merged commit 7198d6b into ROCm:rocm_enabled Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants