Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant image_proc nodes in realsense pipeline #47

Merged
merged 3 commits into from
Sep 6, 2024

Conversation

r2avula
Copy link
Member

@r2avula r2avula commented Sep 3, 2024

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Fix/cleanup

  • What is the current behavior? (You can also link to an open issue here)

There are debayer and rectifying nodes in realsense launch pipeline which are not necessary as the image outputs are already rectified by default when specifying color frame format via config (IntelRealSense/librealsense#91, IntelRealSense/realsense-ros#1670, IntelRealSense/librealsense#11514)

  • What is the new behavior (if this is a feature change)?

Color image outputs from the camera are directly used for creating color pointclouds and for object detection with yolov8.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

No

  • Other information:

@r2avula r2avula requested a review from marvind September 3, 2024 12:08
@r2avula r2avula self-assigned this Sep 3, 2024
@r2avula r2avula changed the title Rrmove redundant image_proc nodes in realsense pipeline Remove redundant image_proc nodes in realsense pipeline Sep 3, 2024
Copy link
Member

@marvind marvind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

@r2avula r2avula merged commit fec144d into humble Sep 6, 2024
1 check passed
@r2avula r2avula deleted the fix/realsense branch September 6, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants