Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nettype: introduce type for ng_netif_hdr_t #2706

Merged
merged 2 commits into from
Mar 27, 2015

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Mar 24, 2015

Introduces nettype for the ng_netif_hdr_t header.

@miri64 miri64 added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation NSTF labels Mar 24, 2015
@miri64 miri64 added this to the Network Stack Task Force milestone Mar 24, 2015
@haukepetersen
Copy link
Contributor

How about putting NG_NETTYPE_NETIF in front of the enum and assigning it to -1. No need to make threads register to it and we can save the 4 bytes in the netreg.

@miri64
Copy link
Member Author

miri64 commented Mar 24, 2015

fine, reverted e4b01c7.

@@ -37,6 +37,11 @@ extern "C" {
* @note Expand at will.
*/
typedef enum {
/**
* @brief Protocol is as defined in @ref ng_netif_hdr_t. Not usable with
* @ref net_ng_netreg
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

net_ng_netreg?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the ng_netreg module. You can't register to type NG_NETTYPE_NETIF there.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh dammit, of course... was slightly confused with the@ref here... never mind.

@haukepetersen
Copy link
Contributor

ACK

@miri64 miri64 force-pushed the nettype/feat/introduce_netif branch from 3fc4e5d to 70c1e4d Compare March 25, 2015 01:11
@miri64
Copy link
Member Author

miri64 commented Mar 25, 2015

Squashed.

miri64 added a commit to miri64/RIOT that referenced this pull request Mar 25, 2015
miri64 added a commit to miri64/RIOT that referenced this pull request Mar 25, 2015
@miri64
Copy link
Member Author

miri64 commented Mar 27, 2015

Travis fails because there it can't rebase to master. Merge?

@miri64
Copy link
Member Author

miri64 commented Mar 27, 2015

The rebase was not possible due to reachability issues to github. Now everything is alright.

=> Go.

miri64 added a commit that referenced this pull request Mar 27, 2015
@miri64 miri64 merged commit 2219d21 into RIOT-OS:master Mar 27, 2015
@miri64 miri64 deleted the nettype/feat/introduce_netif branch March 27, 2015 14:13
@miri64 miri64 added the Area: network Area: Networking label Sep 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: network Area: Networking Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants