Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boards/native: allow to overwrite default fs #18071

Merged
merged 1 commit into from
May 17, 2022
Merged

boards/native: allow to overwrite default fs #18071

merged 1 commit into from
May 17, 2022

Conversation

benpicco
Copy link
Contributor

@benpicco benpicco commented May 8, 2022

Contribution description

The native board is special in that it creates a new storage instance for each test application and provides default mount pints for each file system, so the current hard default is rather arbitrary.

Make this soft default more easy to use by allowing to just supply a different file system without having to remove the vfs_default module (and then manually adding the auto-mount module).

Testing procedure

Add e.g. USEMODULE += fatfs_vfs to tests/vfs_default

  • littlefs2 does not get build
  • an MEMORY.bin image with a FAT fs does not get auto-formatted with littlefs2

Issues/PRs references

@benpicco benpicco requested a review from chrysn May 8, 2022 21:26
@github-actions github-actions bot added Area: boards Area: Board ports Platform: native Platform: This PR/issue effects the native platform labels May 8, 2022
@benpicco benpicco added Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels May 8, 2022
fjmolinas
fjmolinas approved these changes May 17, 2022
View reviewed changes
Copy link
Contributor

@fjmolinas fjmolinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@fjmolinas fjmolinas enabled auto-merge May 17, 2022 08:41
@fjmolinas fjmolinas merged commit 2e1cd2a into RIOT-OS:master May 17, 2022
@benpicco benpicco deleted the boards/native-weak_vfs_default branch May 17, 2022 08:41
@chrysn chrysn added this to the Release 2022.07 milestone Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjmolinas fjmolinas fjmolinas approved these changes

@chrysn chrysn Awaiting requested review from chrysn

Assignees
No one assigned
Labels
Area: boards Area: Board ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Platform: native Platform: This PR/issue effects the native platform
Projects
None yet
Milestone
Release 2022.07
Development

Successfully merging this pull request may close these issues.
3 participants
@benpicco @fjmolinas @chrysn