Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drivers/sx1280: add driver for SX1280 transceiver v2 #18033

Merged
merged 4 commits into from
May 18, 2022
Merged

drivers/sx1280: add driver for SX1280 transceiver v2 #18033

merged 4 commits into from
May 18, 2022

Conversation

Aymeric-Brochier
Copy link
Contributor

@Aymeric-Brochier Aymeric-Brochier commented Apr 28, 2022 •
edited by fjmolinas
Loading

Contribution description

Hello,
This is my first PR feel free to notify me if I am not doing it correctly
I join recently a project which will be using RIOT-OS and one of my task is to contribute to RIOT

This PR is centered about the driver : sx1280 and its adaptation with netdev

Testing procedure

My last test was done with 2 board esp32 WROOM 32

cd tests/driver_sx1280

I am coding from MAC OS and use docker to compile it
I need to add a variable PORT
someting like this :

PORT=/dev/tty.usbserial-14520

esp32-wroom-32

make BOARD=esp32-wroom-32 BUILD_IN_DOCKER=1 flash PORT=$PORT term

Test : getter/setter and some TX/RX with 2 esp-wroom-32

Few simple tests with Getter/Setter

TX/RX on same channel same BW same coding rate same spreading factor (Default) OK

TX/RX on different channel (not seing messages after set another freq) OK
TX/RX on same channel same BW (seing messages after set same freq (Not the default one) and rx start again) OK

TX/RX on same channel diff BW (not seing messages after set another BW) OK
TX/RX on same channel same BW (seing messages after set same BW and rx start again) OK

TX/RX on different sf (not seing messages after set another sf) OK
TX/RX on different sf (seing messages after set same sf and rx start again) OK

TX/RX on different cr (seing messages) I do not know if it is normal since for other parameters it is required to be the same for the communications

Interesting points :

Add a readme
Avoid using the RAL completely
Random function : is it okay like I did it ?

Getter

Welcome to pyterm!
Type '/exit' to exit.
2022-04-28 15:00:32,662 # ets Jun  8 2016 00:22:57
2022-04-28 15:00:32,662 #
2022-04-28 15:00:32,667 # rst:0x1 (POWERON_RESET),boot:0x13 (SPI_FAST_FLASH_BOOT)
2022-04-28 15:00:32,667 # configsip: 0, SPIWP:0xee
2022-04-28 15:00:32,673 # clk_drv:0x00,q_drv:0x00,d_drv:0x00,cs0_drv:0x00,hd_drv:0x00,wp_drv:0x00
2022-04-28 15:00:32,678 # mode:DOUT, clock div:2
2022-04-28 15:00:32,679 # load:0x3fff0018,len:4
2022-04-28 15:00:32,683 # load:0x3fff001c,len:4004
2022-04-28 15:00:32,684 # load:0x40078000,len:7304
2022-04-28 15:00:32,685 # load:0x40080000,len:7224
2022-04-28 15:00:32,686 # entry 0x40080350
2022-04-28 15:00:32,786 #
2022-04-28 15:00:32,795 # main(): This is RIOT! (Version: 2021.10-devel-3491-g23b57-pr/sx1280_v2)
2022-04-28 15:00:32,806 # Initialization successful - starting the shell now
> sx1280
2022-04-28 15:00:39,408 # sx1280
2022-04-28 15:00:39,409 # Usage: sx1280 <get|set|rx|tx>
> sx1280 get
2022-04-28 15:00:44,808 # sx1280 get
2022-04-28 15:00:44,809 # Usage: sx1280 get <type|freq|bw|sf|cr|random>
> sx1280 get type
2022-04-28 15:00:48,064 # sx1280 get type
2022-04-28 15:00:48,065 # Device type: lora
> sx1280 get freq
2022-04-28 15:00:52,639 # sx1280 get freq
2022-04-28 15:00:52,639 # Frequency: 2403000000 Hz
> sx1280 get bw
2022-04-28 15:00:57,130 # sx1280 get bw
2022-04-28 15:00:57,131 # Bandwidth: 800 kHz
> sx1280 get sf
2022-04-28 15:01:01,476 # sx1280 get sf
2022-04-28 15:01:01,477 # Spreading factor: 12
> sx1280 get cr
2022-04-28 15:01:04,271 # sx1280 get cr
2022-04-28 15:01:04,272 # Coding rate: 6
2022-04-28 15:01:04,272 # Usage: use
2022-04-28 15:01:04,277 #      RAL_LORA_CR_4_5 = 0
2022-04-28 15:01:04,278 #      RAL_LORA_CR_4_6 = 1
2022-04-28 15:01:04,278 #      RAL_LORA_CR_4_7 = 2
2022-04-28 15:01:04,282 #      RAL_LORA_CR_4_8 = 3
2022-04-28 15:01:04,283 #      RAL_LORA_CR_LI_4_5 = 4
2022-04-28 15:01:04,287 #      RAL_LORA_CR_LI_4_6 = 5
2022-04-28 15:01:04,288 #      RAL_LORA_CR_LI_4_8 = 6
> sx1280 get random
2022-04-28 15:01:24,852 # sx1280 get random
2022-04-28 15:01:24,891 # random number: 2156170245
> sx1280 get random
2022-04-28 15:01:33,709 # sx1280 get random
2022-04-28 15:01:33,747 # random number: 327578770
> sx1280 get random
2022-04-28 15:01:34,841 # sx1280 get random
2022-04-28 15:01:34,880 # random number: 56624176

Setter

2022-04-28 16:30:53,635 # sx1280
2022-04-28 16:30:53,642 # Usage: sx1280 <get|set|rx|tx>
> sx1280 set
2022-04-28 16:30:56,504 # sx1280 set
2022-04-28 16:30:56,505 # Usage: sx1280 set <freq|bw|sf|cr|> <value>
> sx1280 freq
2022-04-28 16:31:02,802 # sx1280 freq
> sx1280 set freq
2022-04-28 16:31:12,282 # sx1280 set freq
2022-04-28 16:31:12,287 # Usage: use freq between 2400000000 + (bw/2) and 2500000000 - (bw/2) (Hz) !
2022-04-28 16:31:12,290 # Usage: sx1280 set <freq|bw|sf|cr|> <value>
> sx1280 set bw
2022-04-28 16:31:18,924 # sx1280 set bw
2022-04-28 16:31:18,925 # Usage: use 200, 400, 800, 1600 (kHz)
2022-04-28 16:31:18,929 # Usage: sx1280 set <freq|bw|sf|cr|> <value>
> sx1280 set sf
2022-04-28 16:31:23,232 # sx1280 set sf
2022-04-28 16:31:23,233 # Usage: use SF between 5 and 12
2022-04-28 16:31:23,236 # Usage: sx1280 set <freq|bw|sf|cr|> <value>
> sx1280 set cr
2022-04-28 16:31:26,982 # sx1280 set cr
2022-04-28 16:31:26,982 # Usage: use
2022-04-28 16:31:26,983 #      RAL_LORA_CR_4_5 = 0
2022-04-28 16:31:26,988 #      RAL_LORA_CR_4_6 = 1
2022-04-28 16:31:26,988 #      RAL_LORA_CR_4_7 = 2
2022-04-28 16:31:26,989 #      RAL_LORA_CR_4_8 = 3
2022-04-28 16:31:26,993 #      RAL_LORA_CR_LI_4_5 = 4
2022-04-28 16:31:26,994 #      RAL_LORA_CR_LI_4_6 = 5
2022-04-28 16:31:27,000 #      RAL_LORA_CR_LI_4_8 = 6
2022-04-28 16:31:27,001 # Usage: sx1280 set <freq|bw|sf|cr|> <value>

2022-04-28 16:31:27,001 # Usage: sx1280 set <freq|bw|sf|cr|> <value>
> sx1280 set freq 2455555555
2022-04-28 16:32:20,235 # sx1280 set freq 2455555555
2022-04-28 16:32:20,236 # freq set
> sx1280 set bw 200
2022-04-28 16:32:29,468 # sx1280 set bw 200
2022-04-28 16:32:29,468 # setup: setting 200KHz bandwidth
2022-04-28 16:32:29,469 # bw set
> sx1280 set sf 5
2022-04-28 16:32:35,138 # sx1280 set sf 5
2022-04-28 16:32:35,141 # sf set
> sx1280 set cr 4
2022-04-28 16:32:40,970 # sx1280 set cr 4
2022-04-28 16:32:40,973 # cr set

TX/RX

Once we have a shell on both card we can use the shell cmd :

2022-04-28 16:26:48,034 # main(): This is RIOT! (Version: 2021.10-devel-3491-g23b57-pr/sx1280_v2)
2022-04-28 16:26:48,046 # Initialization successful - starting the shell now
help
2022-04-28 16:27:23,060 # help
2022-04-28 16:27:23,061 # Command              Description
2022-04-28 16:27:23,066 # ---------------------------------------
2022-04-28 16:27:23,067 # sx1280               Control the SX1280 radio
2022-04-28 16:27:23,072 # reboot               Reboot the node
2022-04-28 16:27:23,077 # version              Prints current RIOT_VERSION
2022-04-28 16:27:23,082 # pm                   interact with layered PM subsystem
2022-04-28 16:27:23,085 # ps                   Prints information about running threads.
> sx1280
2022-04-28 16:27:27,574 # sx1280
2022-04-28 16:27:27,575 # Usage: sx1280 <get|set|rx|tx>
> sx1280 tx
2022-04-28 16:27:30,710 # sx1280 tx
2022-04-28 16:27:30,711 # Usage: sx1280 tx <payload>
> sx1280 tx test_default_params
2022-04-28 16:28:00,452 # sx1280 tx test_default_params
2022-04-28 16:28:00,455 # sending "test_default_params" payload (20 bytes)
> 2022-04-28 16:28:00,718 # Transmission completed
2022-04-28 16:26:43,538 # Connect to serial port /dev/tty.usbserial-14620
Welcome to pyterm!
Type '/exit' to exit.
sx1280
2022-04-28 16:27:49,686 # sx1280
2022-04-28 16:27:49,687 # Usage: sx1280 <get|set|rx|tx>
> sx1280 rx
2022-04-28 16:27:53,657 # sx1280 rx
2022-04-28 16:27:53,657 # Usage: sx1280 rx <start|stop>
> sx1280 rx start
2022-04-28 16:27:56,596 # sx1280 rx start
2022-04-28 16:27:56,600 # Listen mode started
> 2022-04-28 16:28:00,562 # Data reception started
2022-04-28 16:28:00,726 # Received: "test_default_params" (20 bytes) - [RSSI: -43, SNR: 8]

Issues/PRs references

This PR is not related to known issues but is more a new feature

Closes #17847

@github-actions github-actions bot added Area: doc Area: Documentation Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration Area: LoRa Area: LoRa radio support Area: network Area: Networking Area: pkg Area: External package ports Area: sys Area: System Area: tests Area: tests and testing framework labels Apr 28, 2022
fjmolinas
fjmolinas reviewed Apr 29, 2022
View reviewed changes
Copy link
Contributor

@fjmolinas fjmolinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for this one! Looks much better with the pkg system.

Some initial comments:

  • please use doxygen styled comments so /* */ instead of //.
  • add your copyright and authorship (maybe also Didier/Olivier/Nicolas where relevant), I should not be the single author, I only helped with the pkg.

fjmolinas
fjmolinas reviewed Apr 29, 2022
View reviewed changes
Copy link
Contributor

@fjmolinas fjmolinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more comments, mostly everything I'm commenting are nitpicks.

fjmolinas
fjmolinas reviewed Apr 29, 2022
View reviewed changes
Copy link
Contributor

@fjmolinas fjmolinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more things were pointed out by the static checks.

@fjmolinas fjmolinas added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label May 4, 2022
@fjmolinas
Copy link
Contributor

Lets give the CI a run, although there are still many pending things

fjmolinas
fjmolinas reviewed May 9, 2022
View reviewed changes
MrKevinWeiss
MrKevinWeiss reviewed May 10, 2022
View reviewed changes
Copy link
Contributor

@MrKevinWeiss MrKevinWeiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic PR, I have a few minor remarks but this is probably already beyond the quality that I can provide.

I will see if I have or can get some hardware to test it!

fjmolinas
fjmolinas reviewed May 16, 2022
View reviewed changes
Copy link
Contributor

@fjmolinas fjmolinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final round of review, still standing comments, bust mostly looks good.

I took the liberty yo push some changes to add Kconfig and fix a couple of nitpicks.

@fjmolinas
Copy link
Contributor

I'm going to rebase to remove the unwanted commit.

fjmolinas
fjmolinas reviewed May 17, 2022
View reviewed changes
Copy link
Contributor

@fjmolinas fjmolinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too last nitpicks, you can squash right away after they are applied :)

@fjmolinas
Copy link
Contributor

@aabadie @MrKevinWeiss do you still have comments?

@MrKevinWeiss
Copy link
Contributor

MrKevinWeiss commented May 17, 2022 •
edited
Loading

I will try to look at the changes sometime today. I have some different timezones now.

Last I saw there were some issues with the timer abstraction settings. wrong PR.

@MrKevinWeiss
Copy link
Contributor

No blocking comments from my side. It looks good but I did not test it.

@benpicco benpicco added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels May 17, 2022
@fjmolinas
Copy link
Contributor

fjmolinas commented May 18, 2022 •
edited
Loading

Murdock only showed two failed builds which are unrelated:

--- compile job results (2 failed, 111142 passed, 111144 total):

--- FAILED build outputs:
--- build output of app tests/bench_sched_nop for board ek-lm4f120xl:gnu ([raw](https://ci.riot-os.org/RIOT-OS/RIOT/18033/5833bebe35d575700cf21dc3322ee3f38a5b9720/output/compile/tests/bench_sched_nop/ek-lm4f120xl:gnu.txt), runtime=0.0s):
dwqw@breeze.6: too many deliveries (usual reason: timeout)
---
--- build output of app tests/driver_mq3 for board ruuvitag:gnu ([raw](https://ci.riot-os.org/RIOT-OS/RIOT/18033/5833bebe35d575700cf21dc3322ee3f38a5b9720/output/compile/tests/driver_mq3/ruuvitag:gnu.txt), runtime=0.0s):
dwqw@breeze.7: too many deliveries (usual reason: timeout)
---

@fjmolinas
Copy link
Contributor

@Aymeric-Brochier do you mind posting again some test-output, just for history to know nothing was broken through all the refactoring?

@fjmolinas
Copy link
Contributor

I'll then trigger a fast build and ACK

@Aymeric-Brochier
Copy link
Contributor Author

Aymeric-Brochier commented May 18, 2022 •
edited
Loading

New tests :

Test : getter/setter and some TX/RX with 1 esp-wroom-32 and 1 nucleo

Few simple tests with Getter/Setter OK
TX/RX on same channel same BW same coding rate same spreading factor (Default) OK
TX/RX on different channel (not seing messages after set another freq) OK

TX/RX on same channel same BW (seing messages after set same freq (Not the default one) and rx start again) OK

TX/RX on same channel diff BW (not seing messages after set another BW) OK
TX/RX on same channel same BW (seing messages after set same BW and rx start again) OK
TX/RX on different sf (not seing messages after set another sf) OK
TX/RX on different sf (seing messages after set same sf and rx start again) OK
TX/RX on different cr (seing messages) OK

TX/RX after reseting radio (and re init) OK

I tried to test like if did not know anything :
Starting with help and following what is displayed on the terminal :

2022-05-18 13:09:58,587 # main(): This is RIOT! (Version: 2021.10-devel-3962-g5833be-pr/sx1280_v2)
2022-05-18 13:09:58,595 # Initialization successful - starting the shell now
help
2022-05-18 13:10:15,922 # help
2022-05-18 13:10:15,925 # Command              Description
2022-05-18 13:10:15,928 # ---------------------------------------
2022-05-18 13:10:15,932 # sx1280               Control the SX1280 radio
2022-05-18 13:10:15,935 # reboot               Reboot the node
2022-05-18 13:10:15,940 # version              Prints current RIOT_VERSION
2022-05-18 13:10:15,945 # pm                   interact with layered PM subsystem
> sx1280
2022-05-18 13:10:20,807 # sx1280
2022-05-18 13:10:20,810 # Usage: sx1280 <get|set|rx|tx|reset>
> sx1280 get
2022-05-18 13:11:03,015 # sx1280 get
2022-05-18 13:11:03,019 # Usage: sx1280 get <type|freq|bw|sf|cr>
>
> sx1280 get type
2022-05-18 13:12:28,124 # sx1280 get type
2022-05-18 13:12:28,126 # Device type: lora
> sx1280 get freq
2022-05-18 13:12:33,638 # sx1280 get freq
2022-05-18 13:12:33,640 # Frequency: 2403000000 Hz
> sx1280 get bw
2022-05-18 13:12:40,579 # sx1280 get bw
2022-05-18 13:12:40,581 # Bandwidth: 800 kHz
> sx1280 get sf
2022-05-18 13:12:46,138 # sx1280 get sf
2022-05-18 13:12:46,140 # Spreading factor: 12
> sx1280 get cr
2022-05-18 15:15:12,064 # sx1280 get cr
2022-05-18 15:15:12,070 # Coding rate: 7
2022-05-18 15:15:12,071 # Usage: use
2022-05-18 15:15:12,071 #      LORA_CR_4_5 = 1
2022-05-18 15:15:12,072 #      LORA_CR_4_6 = 2
2022-05-18 15:15:12,072 #      LORA_CR_4_7 = 3
2022-05-18 15:15:12,073 #      LORA_CR_4_8 = 4
2022-05-18 15:15:12,075 #      LORA_CR_LI_4_5 = 5
2022-05-18 15:15:12,075 #      LORA_CR_LI_4_6 = 6
2022-05-18 15:15:12,077 #      LORA_CR_LI_4_8 = 7


> sx1280 set freq
2022-05-18 13:14:28,564 # sx1280 set freq
2022-05-18 13:14:28,571 # Usage: use freq between 2400000000 + (bw/2) and 2500000000 - (bw/2) (Hz) !
2022-05-18 13:14:28,575 # Usage: sx1280 set <freq|bw|sf|cr|> <value>
> sx1280 set freq 2400000000
2022-05-18 13:15:00,984 # sx1280 set freq 2400000000
2022-05-18 13:15:00,986 # cannot set freq
> sx1280 set freq 2440000000
2022-05-18 13:15:16,530 # sx1280 set freq 2400400000
2022-05-18 13:15:16,531 # freq set
> sx1280 set freq 2400399999
2022-05-18 13:15:39,886 # sx1280 set freq 2400399999
2022-05-18 13:15:39,887 # cannot set freq
> sx1280 set freq 2500000000
2022-05-18 13:16:17,554 # sx1280 set freq 2500000000
2022-05-18 13:16:17,556 # cannot set freq

> sx1280 set
2022-05-18 13:17:32,568 # sx1280 set
2022-05-18 13:17:32,572 # Usage: sx1280 set <freq|bw|sf|cr|> <value>
> sx1280 set bw
2022-05-18 13:17:35,862 # sx1280 set bw
2022-05-18 13:17:35,865 # Usage: use 200, 400, 800, 1600 (kHz)
2022-05-18 13:17:35,869 # Usage: sx1280 set <freq|bw|sf|cr|> <value>

2022-05-18 15:22:08,243 # sx1280 set bw 123
2022-05-18 15:22:08,250 # invalid bandwidth, use 200, 400 , 800, 1600
2022-05-18 15:22:08,251 # cannot set bw
> sx1280 set bw 200
2022-05-18 13:18:14,230 # sx1280 set bw 200
2022-05-18 13:18:14,233 # setup: setting 200KHz bandwidth
2022-05-18 13:18:14,234 # bw set
> sx1280 get freq
2022-05-18 13:18:32,933 # sx1280 get freq
2022-05-18 13:18:32,936 # Frequency: 2400400000 Hz
> sx1280 set freq 2400099999
2022-05-18 13:19:19,919 # sx1280 set freq 2400099999
2022-05-18 13:19:19,920 # cannot set freq
> sx1280 set freq 2400100000
2022-05-18 13:19:30,381 # sx1280 set freq 2400100000
2022-05-18 13:19:30,382 # freq set
> sx1280 get freq
2022-05-18 13:19:36,186 # sx1280 get freq
2022-05-18 13:19:36,188 # Frequency: 2400100000 Hz

> sx1280 set sf
2022-05-18 13:20:50,829 # sx1280 set sf
2022-05-18 13:20:50,832 # Usage: use SF between 5 and 12
2022-05-18 13:20:50,836 # Usage: sx1280 set <freq|bw|sf|cr|> <value>
> sx1280 set sf 15
2022-05-18 13:20:58,431 # sx1280 set sf 15
2022-05-18 13:20:58,433 # cannot set sf
> sx1280 set sf 9
2022-05-18 13:21:03,302 # sx1280 set sf 9
2022-05-18 13:21:03,303 # sf set
> sx1280 get sf
2022-05-18 13:21:13,679 # sx1280 get sf
2022-05-18 13:21:13,681 # Spreading factor: 9
sx1280 set sf 12
2022-05-18 13:21:36,691 # sx1280 set sf 12
2022-05-18 13:21:36,692 # sf set

sx1280 get cr
2022-05-18 14:26:34,411 # sx1280 get cr
2022-05-18 14:26:34,413 # Coding rate: 7
2022-05-18 14:26:34,417 # Usage: use
2022-05-18 14:26:34,418 #      LORA_CR_4_5 = 1
2022-05-18 14:26:34,418 #      LORA_CR_4_6 = 2
2022-05-18 14:26:34,423 #      LORA_CR_4_7 = 3
2022-05-18 14:26:34,423 #      LORA_CR_4_8 = 4
2022-05-18 14:26:34,424 #      LORA_CR_LI_4_5 = 5
2022-05-18 14:26:34,427 #      LORA_CR_LI_4_6 = 6
2022-05-18 14:26:34,428 #      LORA_CR_LI_4_8 = 7
> sx1280 set cr 6
2022-05-18 14:27:14,923 # sx1280 set cr 6
2022-05-18 14:27:14,924 # cr set
> sx1280 get cr
2022-05-18 15:15:12,064 # sx1280 get cr
2022-05-18 15:15:12,070 # Coding rate: 7
2022-05-18 15:15:12,071 # Usage: use
2022-05-18 15:15:12,071 #      LORA_CR_4_5 = 1
2022-05-18 15:15:12,072 #      LORA_CR_4_6 = 2
2022-05-18 15:15:12,072 #      LORA_CR_4_7 = 3
2022-05-18 15:15:12,073 #      LORA_CR_4_8 = 4
2022-05-18 15:15:12,075 #      LORA_CR_LI_4_5 = 5
2022-05-18 15:15:12,075 #      LORA_CR_LI_4_6 = 6
2022-05-18 15:15:12,077 #      LORA_CR_LI_4_8 = 7

sx1280 set cr 10
2022-05-18 14:32:29,994 # sx1280 set cr 10
2022-05-18 14:32:30,001 # invalid cr, use
2022-05-18 14:32:30,002 #                  LORA_CR_4_5 = 1
2022-05-18 14:32:30,002 #                  LORA_CR_4_6 = 2
2022-05-18 14:32:30,005 #                  LORA_CR_4_7 = 3
2022-05-18 14:32:30,006 #                  LORA_CR_4_8 = 4
2022-05-18 14:32:30,010 #                  LORA_CR_LI_4_5 = 5
2022-05-18 14:32:30,011 #                  LORA_CR_LI_4_6 = 6
2022-05-18 14:32:30,016 #                  LORA_CR_LI_4_8 = 7
2022-05-18 14:32:30,016 #
2022-05-18 14:32:30,016 # cannot set cr

TX/RX
Not all trace displayed

TX/RX default params :

Terminal 1:

sx1280
2022-05-18 14:54:50,686 # sx1280
2022-05-18 14:54:50,686 # Usage: sx1280 <get|set|rx|tx|reset>
> sx1280 tx
2022-05-18 14:54:54,092 # sx1280 tx
2022-05-18 14:54:54,093 # Usage: sx1280 tx <payload>
> sx1280 tx 123
2022-05-18 14:54:59,850 # sx1280 tx 123
2022-05-18 14:54:59,851 # sending "123" payload (4 bytes)
> 2022-05-18 14:54:59,988 # Transmission completed

Terminal 2 with another card :

2022-05-18 14:54:34,620 # sx1280
2022-05-18 14:54:34,623 # Usage: sx1280 <get|set|rx|tx|reset>
> sx1280 rx
2022-05-18 14:54:42,840 # sx1280 rx
2022-05-18 14:54:42,842 # Usage: sx1280 rx <start|stop>
> sx1280 rx start
2022-05-18 14:54:45,821 # sx1280 rx start
2022-05-18 14:54:45,822 # Listen mode started
> 2022-05-18 14:54:59,955 # Data reception started
2022-05-18 14:54:59,992 # Received: "123" (4 bytes) - [RSSI: -94, SNR: 4]

Other trace available but maybe it should be enough

@fjmolinas
Copy link
Contributor

Please squash! Thanks for re-testing!

fjmolinas
fjmolinas approved these changes May 18, 2022
View reviewed changes
Copy link
Contributor

@fjmolinas fjmolinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK!

@fjmolinas fjmolinas enabled auto-merge May 18, 2022 20:06
@fjmolinas fjmolinas merged commit 37da85f into RIOT-OS:master May 18, 2022
@fjmolinas
Copy link
Contributor

Congrats @Aymeric-Brochier thanks for sticking through and for all the refactoring from #17847, super cool to see this one in!

@chrysn chrysn added this to the Release 2022.07 milestone Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aabadie aabadie aabadie left review comments

@MrKevinWeiss MrKevinWeiss MrKevinWeiss left review comments

@fjmolinas fjmolinas fjmolinas approved these changes

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@smlng smlng Awaiting requested review from smlng

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@miri64 miri64 Awaiting requested review from miri64

@haukepetersen haukepetersen Awaiting requested review from haukepetersen

@PeterKietzmann PeterKietzmann Awaiting requested review from PeterKietzmann

@cgundogan cgundogan Awaiting requested review from cgundogan

Assignees
No one assigned
Labels
Area: doc Area: Documentation Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration Area: LoRa Area: LoRa radio support Area: network Area: Networking Area: pkg Area: External package ports Area: sys Area: System Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Milestone
Release 2022.07
Development

Successfully merging this pull request may close these issues.
6 participants
@Aymeric-Brochier @fjmolinas @MrKevinWeiss @aabadie @chrysn @benpicco