Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boards: remove support for wsn430-1_3b and wsn430-1_4 #14491

Merged
merged 5 commits into from
Jul 10, 2020
Merged

boards: remove support for wsn430-1_3b and wsn430-1_4 #14491

merged 5 commits into from
Jul 10, 2020

Conversation

aabadie
Copy link
Contributor

@aabadie aabadie commented Jul 10, 2020 •
edited
Loading

Contribution description

The WSN430 boards are no longer available on the iot-lab testbed.

Thus, this PR:

  • removes the support for both boards
  • removes the mapping of these boards from the testbed support integration in the build system (via IOTLAB_NODE)
  • removes all occurrences of the boards in applications' Makefile and Makefile.ci.

Regarding the change in LOSTANDFOUND: for the commit hash to be correct, I think it should be provided in a separate PR and the commit hash to reference the merge commit ?

Testing procedure

  • no more reference to wsn430/WSN430 in the codebase
  • Integration of other iotlab boards still works

Issues/PRs references

None

@aabadie aabadie added Area: build system Area: Build system CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs labels Jul 10, 2020
@miri64
Copy link
Member

miri64 commented Jul 10, 2020

Maybe also add a deprecation note to the respective boards doc.

@aabadie
Copy link
Contributor Author

aabadie commented Jul 10, 2020

Maybe also add a deprecation note to the respective boards doc.

This PR is not removing them, just the integration with the IOTLAB_NODE variable. I'm finalizing the other PR that is actually removing them completely.

@aabadie aabadie force-pushed the pr/remove_wsn430_iotlab branch from 0db7128 to 7298cf9 Compare July 10, 2020 14:10
@aabadie aabadie changed the title dist/testbed-support: remove iotlab wsn430 mapping boards: remove support for wsn430-1_3b and wsn430-1_4 Jul 10, 2020
@aabadie aabadie added Area: boards Area: Board ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jul 10, 2020
@aabadie
Copy link
Contributor Author

aabadie commented Jul 10, 2020 •
edited
Loading

I finally added all removal of the wsn430 boards in this PR and updated the title.

@miri64 miri64 added the Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation label Jul 10, 2020
miri64
miri64 reviewed Jul 10, 2020
View reviewed changes
@aabadie aabadie force-pushed the pr/remove_wsn430_iotlab branch from 7298cf9 to 5555dd3 Compare July 10, 2020 14:49
@aabadie aabadie mentioned this pull request Jul 10, 2020
Merged
miri64
miri64 approved these changes Jul 10, 2020
View reviewed changes
Copy link
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. With the boards removed from IoT-LAB there is not much sense to support them anymore and a deprecation period would be counterproductive. wsn430 does not show up in tree with this PR and #14495 will update the LOSTANDFOUND.md.

$ git grep "wsn430" || echo "Nothing to be found"
Nothing to be found

@aabadie aabadie merged commit e63cd54 into RIOT-OS:master Jul 10, 2020
@aabadie aabadie deleted the pr/remove_wsn430_iotlab branch July 10, 2020 18:40
@miri64 miri64 mentioned this pull request Jul 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miri64 miri64 miri64 approved these changes

@cgundogan cgundogan Awaiting requested review from cgundogan

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@MrKevinWeiss MrKevinWeiss Awaiting requested review from MrKevinWeiss MrKevinWeiss is a code owner

@smlng smlng Awaiting requested review from smlng

Assignees
No one assigned
Labels
Area: boards Area: Board ports Area: build system Area: Build system CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aabadie @miri64