Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpu/esp*: esp_wifi used as default netdev for lwip #13004

Merged
merged 1 commit into from
Jan 11, 2020

Conversation

gschorcht
Copy link
Contributor

Contribution description

With this PR, esp-wifi is defined as default network device for pkg/lwip.

Normally, esp_now is used as the default network device for ESP modules. However, esp_now cannot be used together with pkg/lwip. Therefore, esp_wifi is used instead as the default network device if module lwip is enabled.

Testing procedure

Flash tests/lwip to any ESP32 and any ESP8266 board and ping the nodes from any machine in the LAN.

LWIP_IPV4=1 CFLAGS='-DESP_WIFI_SSID=\"ssid\" -DESP_WIFI_PASS=\"pass\"' \
make BOARD=esp32-wroom-32 -C tests/lwip flash term
LWIP_IPV4=1 CFLAGS='-DESP_WIFI_SSID=\"ssid\" -DESP_WIFI_PASS=\"pass\"' \
make BOARD=esp8266-esp-12x -C tests/lwip flash term

Issues/PRs references

@benpicco benpicco added Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation labels Dec 26, 2019
@gschorcht gschorcht added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Dec 27, 2019
@gschorcht
Copy link
Contributor Author

@benpicco Thanks for setting the labels. I just forgot it because of the limited time I have on my holiday trip..

@gschorcht gschorcht added the Platform: ESP Platform: This PR/issue effects ESP-based platforms label Dec 27, 2019
Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
I'd suggest moving that entire block to esp_common/Makefile.include though.
Duplicate code blocks like this will just get out-of sync eventually and there is nothing esp32/8266 specific here.

@gschorcht
Copy link
Contributor Author

gschorcht commented Jan 11, 2020

Looks good.
I'd suggest moving that entire block to esp_common/Makefile.include though.
Duplicate code blocks like this will just get out-of sync eventually and there is nothing esp32/8266 specific here.

Yeah. It's just an interim solution. There is already PR #12955 with complete code deduplication where it will be in esp_common/Makefile.include.

@benpicco benpicco merged commit ab246a8 into RIOT-OS:master Jan 11, 2020
@gschorcht
Copy link
Contributor Author

Thanks for reviewing and merging.

@gschorcht gschorcht deleted the cpu/esp/lwip_default_esp_wifi branch January 11, 2020 14:55
@fjmolinas fjmolinas added this to the Release 2020.01 milestone Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ESP Platform: This PR/issue effects ESP-based platforms Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants