Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emb6: deprecate package #12389

Merged
merged 2 commits into from
Oct 9, 2019
Merged

emb6: deprecate package #12389

merged 2 commits into from
Oct 9, 2019

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Oct 8, 2019

Contribution description

I basically didn't work on emb6 since 2016 and adapting to the newest version would mean some major overhaul. However, the development at their end seems to be stalled since March 2018 as well. All this speaks for deprecating this package.

Testing procedure

Read, compile make doc, it should show up in the deprecated list (doc/doxygen/html/deprecated.html)

Issues/PRs references

None

@miri64 miri64 added Area: network Area: Networking Area: pkg Area: External package ports Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 8, 2019
@miri64 miri64 added this to the Release 2019.10 milestone Oct 8, 2019
Copy link
Member

@kb2ma kb2ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This deprecation is reasonable. However, I don't see an entry for emb6 in the current online documentation. Also, I don't see it when I build locally, and the deprecation notice does not appear. Am I missing something?

@aabadie
Copy link
Contributor

aabadie commented Oct 9, 2019

Am I missing something?

See #8664. emb6 documentation is not parsed by doxygen.

@miri64
Copy link
Member Author

miri64 commented Oct 9, 2019

Mh... it was excluded in #8665, but as far as I can see there is just one element that isn't documented. Should be a straight forward fix. Will do.

@miri64
Copy link
Member Author

miri64 commented Oct 9, 2019

Fixed the documentation for emb6 in general and addressed @kb2ma's comment.

@kb2ma
Copy link
Member

kb2ma commented Oct 9, 2019

Fix is good. The package doc builds now, and I see the deprecation notice. I haven't used emb6, but I can accept that the package documentation is good. Even if not, it's a start and can be extended if emb6 is revived.

Please squash.

I basically didn't work on `emb6` since 2016 and adapting to the newest
version would mean some major overhaul. However, the development at
their end seems to be stalled [since March 2018][emb6-develop] as well.
All this speaks for deprecating this package.

[emb6-develop]: https://github.com/hso-esk/emb6/tree/develop
@miri64
Copy link
Member Author

miri64 commented Oct 9, 2019

Squashed

@kb2ma kb2ma merged commit 3e0a3b1 into RIOT-OS:master Oct 9, 2019
@miri64 miri64 deleted the pkg/depr/emb6 branch October 9, 2019 11:29
miri64 added a commit to RIOT-OS/Release-Specs that referenced this pull request Jul 11, 2020
`emb6` was deprecated in [1] and removed in [2] so it does not make
much sense to test this anymore, even for 2020.07.

[1] RIOT-OS/RIOT#12389
[2] RIOT-OS/RIOT#14494
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: network Area: Networking Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants