-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
emb6: deprecate package #12389
emb6: deprecate package #12389
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This deprecation is reasonable. However, I don't see an entry for emb6 in the current online documentation. Also, I don't see it when I build locally, and the deprecation notice does not appear. Am I missing something?
See #8664. emb6 documentation is not parsed by doxygen. |
Mh... it was excluded in #8665, but as far as I can see there is just one element that isn't documented. Should be a straight forward fix. Will do. |
Fixed the documentation for |
Fix is good. The package doc builds now, and I see the deprecation notice. I haven't used emb6, but I can accept that the package documentation is good. Even if not, it's a start and can be extended if emb6 is revived. Please squash. |
I basically didn't work on `emb6` since 2016 and adapting to the newest version would mean some major overhaul. However, the development at their end seems to be stalled [since March 2018][emb6-develop] as well. All this speaks for deprecating this package. [emb6-develop]: https://github.com/hso-esk/emb6/tree/develop
Squashed |
`emb6` was deprecated in [1] and removed in [2] so it does not make much sense to test this anymore, even for 2020.07. [1] RIOT-OS/RIOT#12389 [2] RIOT-OS/RIOT#14494
Contribution description
I basically didn't work on
emb6
since 2016 and adapting to the newest version would mean some major overhaul. However, the development at their end seems to be stalled since March 2018 as well. All this speaks for deprecating this package.Testing procedure
Read, compile
make doc
, it should show up in the deprecated list (doc/doxygen/html/deprecated.html
)Issues/PRs references
None