Variable.__repr__ should return a python representation string, not n3 #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For other terms like `URIRef`, `Literal` and `BNodes` we return a
`repr` string that is a string representation of the term and allows
re-creating the object when passed to `eval`. Variable isn't that
consistent it seems:
```python
In [1]: import rdflib
INFO:rdflib:RDFLib Version: 4.2.1-dev
In [2]: eval(repr(rdflib.term.URIRef('foo')))
Out[2]: rdflib.term.URIRef(u'foo')
In [3]: eval(repr(rdflib.term.Variable('foo')))
File "<string>", line 1
?foo
^
SyntaxError: invalid syntax
```
https://docs.python.org/2/library/functions.html#func-repr doesn't
really enforce this, but it's nice to have for debugging for example.
This commit returns a repr like `rdflib.term.Variable('foo')`.
joernhees
added a commit
that referenced
this pull request
Jun 22, 2015
Variable.__repr__ should return a python representation string, not n3
This was referenced Jan 16, 2017
This was referenced Mar 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For other terms like
URIRef,LiteralandBNodeswe return areprstring that is a string representation of the term and allowsre-creating the object when passed to
eval. Variable isn't thatconsistent it seems:
https://docs.python.org/2/library/functions.html#func-repr doesn't
really enforce this, but it's nice to have for debugging for example.
This commit returns a repr like
rdflib.term.Variable('foo').