trig output fixes #480
Merged
trig output fixes #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before: "<short:name> {...}" and "<None> {...}"
After: "short:name {...}" and "<http://actual/uri/here> {...}"
| p = triple[1] | ||
| if isinstance(p, BNode): | ||
| self._references[p]+=1 | ||
|
|
There was a problem hiding this comment.
did you remove this on purpose? seems it is called from preprocess and the one in TurtleSerializer looks quite different to me
There was a problem hiding this comment.
TurtleSerializer's one is a super call followed by a repeat of lines 48-57. The super call would run RecursiveSerializer's method, which is a repeat of lines 45-47. Most importantly, the test suite still passes :)
There was a problem hiding this comment.
ah sorry, i must have looked at the RecursiveSerializer one directly... so essentially this was unnecessary code duplication?
|
thanks for the changes and comments, i think this looks good now... |
This was referenced Jan 16, 2017
This was referenced Mar 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.