Added trig unit tests to highlight some current parsing/serializing issues #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 31, 2014
|
I've rebased this onto current master, and apart from Test RoundTrip fails due to #436 - and it can't really be fixed in 4.2.2 without changing the API somewhere. I'll push this to 5.0 |
|
I've added some more commits in #699 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some TriG unit tests that currently fail (but should pass when issues are resolved).
testGraphParsingcurrently fails due to the TriG parser treating triples in the default graph with and without enclosing braces as 2 separate contexts, whereas they should both be treated as one.testRoundTripstests whether repeatedly parsing/serializing the same data results in a graph containing the same items. Currently this fails due to a combination of the issue mentioned above, and due to an issue with handling QNames in the TriG serializer.testDefaultGraphSerializesWithoutNamechecks that triples in the default graph are serialized correctly. Currently this fails, as the default graph is serialized as<None> { ... }.I'm planning to look into fixes for these, but thought adding some failing unit tests first would be more useful, in case anyone else wants to look at or fix them too.