fix: range of sh:path should be blank node not RDF Collection #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on. This is a basic error/typo that has been present for some time and somehow not caused issues until now. Using an RDF Collection meant that one of either the union of property paths OR the shacl:union property itself were processed, potentially RDFLib typically ordered these internally in such a way that the list and not sh:union was processed. Olis seems to have disrupted this. In any case, use of an RDF Collection is wrong.
lalewis1
approved these changes
Mar 25, 2025
|
🎉 This PR is included in version 4.6.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shacl path should have a bnode as it's range not an RDF Collection. This is a basic error/typo that has been present for some time and somehow not caused issues until now (potentially due to default RDF ordering in RDFLib). Using an RDF Collection meant that one of either the union of property paths OR the shacl:union property itself were processed, potentially RDFLib typically ordered these internally in such a way that the list and not sh:union was processed. Olis seems to have disrupted this. In any case, use of an RDF Collection is wrong.
The following two changes have been made: