Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tailwind v4 #7274

Merged
merged 3 commits into from
Jan 25, 2025
Merged

tailwind v4 #7274

merged 3 commits into from
Jan 25, 2025

Conversation

sreeisalso
Copy link
Contributor

What is it?

  • Feature / enhancement

Description

tailwind css v4

Checklist

  • My code follows the developer guidelines of this project
  • I performed a self-review of my own code
  • I added a changeset with pnpm change
  • I made corresponding changes to the Qwik docs
  • I added new tests to cover the fix / functionality

Copy link

changeset-bot bot commented Jan 24, 2025

🦋 Changeset detected

Latest commit: 45ec1a1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@builder.io/qwik Patch
eslint-plugin-qwik Patch
@builder.io/qwik-city Patch
create-qwik Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 24, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 45ec1a1

@sreeisalso sreeisalso marked this pull request as ready for review January 24, 2025 06:59
@sreeisalso sreeisalso requested review from a team as code owners January 24, 2025 06:59
@sreeisalso
Copy link
Contributor Author

why pkg.pr is not geenrated forr this pr?

wmertens
wmertens previously approved these changes Jan 24, 2025
Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 LGTM!

@wmertens
Copy link
Member

why pkg.pr is not geenrated forr this pr?

Because the qwik core didn't get detected as changed, let me fix that.

@wmertens
Copy link
Member

ok I added a commit and now the pr new should be created. Once you can confirm that it works, we can merge.

Copy link

pkg-pr-new bot commented Jan 24, 2025

Open in Stackblitz

npm i https://pkg.pr.new/@builder.io/qwik@7274
npm i https://pkg.pr.new/@builder.io/qwik-city@7274
npm i https://pkg.pr.new/eslint-plugin-qwik@7274
npm i https://pkg.pr.new/create-qwik@7274

commit: 45ec1a1

@sreeisalso
Copy link
Contributor Author

it is working as expected

@sreeisalso sreeisalso requested a review from wmertens January 25, 2025 10:02
@wmertens wmertens merged commit 307bbd5 into QwikDev:main Jan 25, 2025
19 checks passed
@wmertens
Copy link
Member

Thanks!

@github-actions github-actions bot mentioned this pull request Jan 25, 2025
@sreeisalso sreeisalso deleted the tailwindv4 branch January 26, 2025 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants