Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: retry vnode diffing on promise throw #7259

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

Varixo
Copy link
Member

@Varixo Varixo commented Jan 15, 2025

  • throwing a promise is our way to await for QRL to resolve. We need to catch the promise while vnode diffing
  • during effects cleanup we shouldn't read the props directly and sometimes create a new subscription

@Varixo Varixo self-assigned this Jan 15, 2025
@Varixo Varixo requested a review from a team as a code owner January 15, 2025 19:07
Copy link

changeset-bot bot commented Jan 15, 2025

🦋 Changeset detected

Latest commit: 3f4af53

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@qwik.dev/core Patch
eslint-plugin-qwik Patch
@qwik.dev/react Patch
@qwik.dev/router Patch
create-qwik Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Jan 15, 2025

Open in Stackblitz

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@7259
npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@7259
npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@7259
npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@7259

commit: 3f4af53

Copy link
Contributor

github-actions bot commented Jan 15, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 3f4af53

@Varixo Varixo merged commit 9b92141 into build/v2 Jan 17, 2025
19 checks passed
@Varixo Varixo deleted the v2-retry-vnode-diff-on-promise-throw branch January 17, 2025 10:20
Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants