fix: destructured props for inline components #7190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d8a19ca The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
d398081 to
f7893ea
Compare
f7893ea to
d391dda
Compare
d391dda to
48af55c
Compare
wmertens
reviewed
Dec 25, 2024
| @@ -9,7 +9,7 @@ snapshot_kind: text | |||
|
|
|||
| import { $, component$ } from '@qwik.dev/core'; | |||
|
|
|||
| export const Foo = component$(({color}) => { | |||
| export const Foo = component$((props) => { | |||
There was a problem hiding this comment.
This one was wrong actually, maybe we want to use some props? Not sure if important
There was a problem hiding this comment.
What do you mean? Later we use ...props and never the color, so I think now it is correct?
or do you mean that this error is intentional?
There was a problem hiding this comment.
No it was destructuring color but using props
There was a problem hiding this comment.
yeah, and it was wrong, right? or should I revert it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert destructured props for an inline component to single prop