Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2: make optimizer async + remove fs #7040

Merged
merged 2 commits into from
Nov 4, 2024
Merged

v2: make optimizer async + remove fs #7040

merged 2 commits into from
Nov 4, 2024

Conversation

wmertens
Copy link
Member

@wmertens wmertens commented Nov 3, 2024

This removes the unused cli and fs functions from the optimizer, and it makes the optimizer async with the tokio rust package which manages a thread pool and automatically runs uses all available cores for transforming.

However, it doesn't result in that much speedup because the optimization is fast and most of the build time is spent on other things. Insights build is unchanged and docs build seems to be 10s faster.

Copy link

changeset-bot bot commented Nov 3, 2024

⚠️ No Changeset found

Latest commit: de3052f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Nov 3, 2024

Open in Stackblitz

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@7040
npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@7040
npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@7040
npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@7040

commit: de3052f

Copy link
Contributor

github-actions bot commented Nov 4, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview de3052f

@wmertens wmertens marked this pull request as ready for review November 4, 2024 07:48
@wmertens wmertens requested review from a team as code owners November 4, 2024 07:48
@wmertens wmertens self-assigned this Nov 4, 2024
@wmertens wmertens added COMP: optimizer STATUS-2: PR waiting for review This PR is waiting for review and approval before merge labels Nov 4, 2024
Copy link
Member

@Varixo Varixo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shairez shairez merged commit bd98e33 into build/v2 Nov 4, 2024
22 checks passed
@shairez shairez deleted the async-optimizer branch November 4, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
COMP: optimizer STATUS-2: PR waiting for review This PR is waiting for review and approval before merge
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants