Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): add PkgManagers tabs #6636

Merged
merged 25 commits into from
Aug 1, 2024
Merged

Conversation

gioboa
Copy link
Member

@gioboa gioboa commented Jul 2, 2024

image

image

Copy link

netlify bot commented Jul 2, 2024

‼️ Deploy request for qwik-insights rejected.

Name Link
🔨 Latest commit 5d8a492

@gioboa gioboa mentioned this pull request Jul 2, 2024
7 tasks
Copy link

pkg-pr-new bot commented Jul 2, 2024

commit: 5c48714

npm i https://pkg.pr.new/@builder.io/qwik@6636
npm i https://pkg.pr.new/@builder.io/qwik-city@6636
npm i https://pkg.pr.new/eslint-plugin-qwik@6636
npm i https://pkg.pr.new/create-qwik@6636

Open in Stackblitz

@gioboa gioboa force-pushed the feat/pkg-managers-tabs branch from 1478db9 to d24da52 Compare July 3, 2024 14:16
Copy link

changeset-bot bot commented Jul 18, 2024

⚠️ No Changeset found

Latest commit: 3cc117a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gioboa gioboa marked this pull request as ready for review July 19, 2024 12:40
@gioboa gioboa requested review from a team as code owners July 19, 2024 12:40
@gioboa
Copy link
Member Author

gioboa commented Jul 19, 2024

It builds correctly
image

@thejackshelton thejackshelton requested a review from a team as a code owner July 28, 2024 05:12
PatrickJS
PatrickJS previously approved these changes Jul 31, 2024
Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wmertens wmertens merged commit 99d6db4 into QwikDev:main Aug 1, 2024
13 of 14 checks passed
@gioboa gioboa deleted the feat/pkg-managers-tabs branch August 1, 2024 08:40
maiieul added a commit to maiieul/qwik that referenced this pull request Aug 26, 2024
maiieul added a commit to maiieul/qwik that referenced this pull request Aug 27, 2024
maiieul added a commit to maiieul/qwik that referenced this pull request Aug 27, 2024
maiieul added a commit to maiieul/qwik that referenced this pull request Aug 27, 2024
maiieul added a commit to maiieul/qwik that referenced this pull request Aug 27, 2024
maiieul added a commit to maiieul/qwik that referenced this pull request Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants