Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rust): update all deps + fixups #6005

Merged
merged 12 commits into from
Aug 1, 2024
Merged

Conversation

wmertens
Copy link
Member

@wmertens wmertens commented Mar 13, 2024

Napi v1 doesn't work on ARM macs. So we need to upgrade to v2 as well, or use the wasm optimizer on ARM macs.

UPDATE: after upgrading to napi v2, everything builds and runs, but cargo test no longer works, breaking on qwik-napi. Seems like a cosmetic issue.

UPDATE: worked around by only building what's needed for cargo test.

Copy link

netlify bot commented Mar 13, 2024

👷 Deploy request for qwik-insights pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 8668ca7

@wmertens wmertens force-pushed the update-rust branch 7 times, most recently from a5d6d38 to 3e3aea0 Compare March 15, 2024 12:36
@wmertens wmertens force-pushed the update-rust branch 2 times, most recently from 17a02db to 8668ca7 Compare March 30, 2024 22:28
@shairez
Copy link
Contributor

shairez commented Apr 6, 2024

@wmertens do you need help with this one?
running into the same issues of when trying to build the repo

@wmertens wmertens force-pushed the update-rust branch 2 times, most recently from a9afa7c to 7500b5d Compare April 28, 2024 15:56
@wmertens wmertens requested a review from a team as a code owner July 19, 2024 08:21
Copy link

changeset-bot bot commented Jul 19, 2024

🦋 Changeset detected

Latest commit: 4b4a88d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@builder.io/qwik Minor
eslint-plugin-qwik Minor
@builder.io/qwik-city Minor
create-qwik Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Jul 19, 2024

‼️ Deploy request for qwik-insights rejected.

Name Link
🔨 Latest commit 0a98c03

@wmertens wmertens force-pushed the update-rust branch 2 times, most recently from 0a98c03 to 61d3ad7 Compare July 19, 2024 11:33
Copy link

pkg-pr-new bot commented Jul 19, 2024

commit: 4b4a88d

npm i https://pkg.pr.new/@builder.io/qwik@6005
npm i https://pkg.pr.new/@builder.io/qwik-city@6005
npm i https://pkg.pr.new/eslint-plugin-qwik@6005
npm i https://pkg.pr.new/create-qwik@6005

Open in Stackblitz

@wmertens wmertens force-pushed the update-rust branch 3 times, most recently from 5b461a7 to 9cad06f Compare July 21, 2024 19:38
@wmertens wmertens requested a review from a team as a code owner July 21, 2024 19:38
@wmertens wmertens force-pushed the update-rust branch 4 times, most recently from b6ed306 to 9cad06f Compare July 21, 2024 21:47
@wmertens wmertens force-pushed the update-rust branch 4 times, most recently from 679e082 to 65dd404 Compare July 31, 2024 13:43
@wmertens wmertens requested a review from a team as a code owner July 31, 2024 16:22
@wmertens wmertens force-pushed the update-rust branch 2 times, most recently from 871853b to aa42f17 Compare August 1, 2024 08:27
wmertens added 12 commits August 1, 2024 10:50
note that typescript will now shortcut enums
typescript-eslint/ruletester assumes eslint 9 in a minor update. Besides, we need reproducability.
- except eslint rule checker
- and also bump vite
- and fix some prod and peer deps to have ^
- configure syncpack to keep prod and dev deps separate
- prettier
- downgrade vfile to 6.0.1 because of e2e test failure
they somehow got broken by updates
also make e2e timeouts longer
@shairez
Copy link
Contributor

shairez commented Aug 1, 2024

thanks @wmertens !
Great job!

@shairez shairez merged commit 42880cf into QwikDev:main Aug 1, 2024
16 of 17 checks passed
This was referenced Aug 1, 2024
@wmertens wmertens deleted the update-rust branch October 17, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants