fix(insights): move default location to root

so it doesn't get clobbered by builds

packages/docs/.gitignore

@@ -18,6 +18,7 @@ node_modules
 .vscode
 .rollup.cache
 tsconfig.tsbuildinfo
+q-insights.json
 
 # Logs
 logs

packages/qwik-labs/src-vite/insights/index.ts

@@ -20,7 +20,7 @@ export async function qwikInsights(qwikInsightsOpts: {
   baseUrl?: string;
   outDir?: string;
 }): Promise<PluginOption> {
-  const { publicApiKey, baseUrl = 'https://insights.qwik.dev', outDir = 'dist' } = qwikInsightsOpts;
+  const { publicApiKey, baseUrl = 'https://insights.qwik.dev', outDir = '' } = qwikInsightsOpts;
   let isProd = false;
   const vitePlugin: PluginOption = {
     name: 'vite-plugin-qwik-insights',

packages/qwik/src/optimizer/src/plugins/vite.ts

@@ -76,12 +76,12 @@ export function qwikVite(qwikViteOpts: QwikVitePluginOptions = {}): any {
   const injections: GlobalInjections[] = [];
   const qwikPlugin = createPlugin(qwikViteOpts.optimizerOptions);
 
-  async function loadQwikInsights(clientOutDir?: string | null): Promise<InsightManifest | null> {
+  async function loadQwikInsights(clientOutDir = ''): Promise<InsightManifest | null> {
     const sys = qwikPlugin.getSys();
     const cwdRelativePath = absolutePathAwareJoin(
       sys.path,
       rootDir || '.',
-      clientOutDir ?? 'dist',
+      clientOutDir,
       'q-insights.json'
     );
     const path = absolutePathAwareJoin(sys.path, process.cwd(), cwdRelativePath);
@@ -97,7 +97,7 @@ export function qwikVite(qwikViteOpts: QwikVitePluginOptions = {}): any {
     getOptimizer: () => qwikPlugin.getOptimizer(),
     getOptions: () => qwikPlugin.getOptions(),
     getManifest: () => manifestInput,
-    getInsightsManifest: (clientOutDir?: string | null) => loadQwikInsights(clientOutDir),
+    getInsightsManifest: (clientOutDir = '') => loadQwikInsights(clientOutDir!),
     getRootDir: () => qwikPlugin.getOptions().rootDir,
     getClientOutDir: () => clientOutDir,
     getClientPublicOutDir: () => clientPublicOutDir,
@@ -225,7 +225,7 @@ export function qwikVite(qwikViteOpts: QwikVitePluginOptions = {}): any {
             } catch (e) {
               console.error(e);
             }
-          } catch (e) {
+          } catch {
             // error reading package.json from Node.js fs, ok to ignore
           }
 
@@ -429,7 +429,7 @@ export function qwikVite(qwikViteOpts: QwikVitePluginOptions = {}): any {
           if (entryStrategy) {
             qwikViteOpts.entryStrategy = entryStrategy;
           }
-        } catch (e) {
+        } catch {
           // ok to ignore
         }
       }