Fix RuboCop annotations failures

.rubocop.yml

@@ -1,3 +1,7 @@
+AllCops:
+  NewCops: enable
+  TargetRubyVersion: 2.6
+
 Layout/LineLength:
   Exclude:
     - spec/**/*

CHANGES.md

@@ -4,6 +4,8 @@
 - Enable Github actions for ruby 3
 - Enable Rubocop linting
 - Bump compatibility to sidekiq 7
+- More stringent RuboCop tests
+- Enable RubyGems MFA required
 
 ## 0.1.5
 - RSpec Matchers for testing, thanks to [rspec-rails](https://github.com/rspec/rspec-rails) for their ActionCable `have_broadcasted_to` matcher as reference

Gemfile

@@ -4,3 +4,11 @@ source 'https://rubygems.org'
 
 # Specify your gem's dependencies in teams_connector.gemspec
 gemspec
+
+gem 'bundler', '>= 1.17'
+gem 'rake', '>= 10.0'
+gem 'rspec', '>= 3.0'
+gem 'rubocop'
+gem 'sidekiq', '< 8'
+gem 'simplecov'
+gem 'webmock'

spec/teams_connector/builder_spec.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 RSpec.describe TeamsConnector::Builder do
-  subject { TeamsConnector::Builder.new {} }
+  subject { TeamsConnector::Builder.new { nil } }
 
   it 'is a builder' do
     is_expected.to be_a TeamsConnector::Builder

spec/teams_connector/configuration_spec.rb

@@ -85,10 +85,10 @@ def self.application
       it 'loads channels from credentials' do
         stub_const 'Rails', RailsTest
         allow(Rails.application.credentials)
-          .to receive(:"teams_connector!").and_return({
-                                                        credentials_default: 'DEFAULT_TEST_URL',
-                                                        credentials_other: 'OTHER_TEST_URL'
-                                                      })
+          .to receive(:teams_connector!).and_return({
+                                                      credentials_default: 'DEFAULT_TEST_URL',
+                                                      credentials_other: 'OTHER_TEST_URL'
+                                                    })
         subject.load_from_rails_credentials
         channels = [
           { credentials_default: 'DEFAULT_TEST_URL' },

spec/teams_connector/matchers/have_sent_notification_to_spec.rb

@@ -42,7 +42,7 @@ def notification(template, channels)
     end
 
     it 'passes when negated' do
-      expect {}.not_to sent_notification_to?(:default)
+      expect { nil }.not_to sent_notification_to?(:default)
     end
 
     it 'passes with multiple channels' do
@@ -99,7 +99,7 @@ def notification(template, channels)
 
     it 'fails when notification is not sent' do
       expect do
-        expect {}.to sent_notification_to?(:default)
+        expect { nil }.to sent_notification_to?(:default)
       end.to raise_error(/expected to send exactly 1 notifications to default, but sent 0/)
     end
 
@@ -115,8 +115,7 @@ def notification(template, channels)
     it 'reports correct number in fail error message' do
       notification(:test_card, :default)
       expect do
-        expect do
-        end.to sent_notification_to?(:default).exactly(1)
+        expect { nil }.to sent_notification_to?(:default).exactly(1)
       end.to raise_error(/expected to send exactly 1 notifications to default, but sent 0/)
     end
 
@@ -200,7 +199,7 @@ def notification(template, channels)
       end
 
       it 'passes when negated' do
-        expect {}.not_to sent_notification_to?(nil, :test_card)
+        expect { nil }.not_to sent_notification_to?(nil, :test_card)
       end
 
       it 'counts only notifications sent with the template' do

spec/teams_connector/notification_spec.rb

@@ -26,15 +26,15 @@
   it 'delivers the message to the target' do
     subject.deliver_later
 
-    expect(WebMock).to have_requested(:post, 'http://localhost').with headers: { "Content-Type": 'application/json' }
+    expect(WebMock).to have_requested(:post, 'http://localhost').with headers: { 'Content-Type': 'application/json' }
     expect(WebMock).not_to have_requested :post, 'http://default'
   end
 
   it 'delivers the message to the default target' do
     TeamsConnector.configuration.always_use_default = true
     subject.deliver_later
 
-    expect(WebMock).to have_requested(:post, 'http://default').with headers: { "Content-Type": 'application/json' }
+    expect(WebMock).to have_requested(:post, 'http://default').with headers: { 'Content-Type': 'application/json' }
     expect(WebMock).not_to have_requested :post, 'http://localhost'
   end
 
@@ -48,16 +48,16 @@
     it 'delivers the message to all targets' do
       subject.deliver_later
 
-      expect(WebMock).to have_requested(:post, 'http://localhost').with headers: { "Content-Type": 'application/json' }
-      expect(WebMock).to have_requested(:post, 'http://another').with headers: { "Content-Type": 'application/json' }
+      expect(WebMock).to have_requested(:post, 'http://localhost').with headers: { 'Content-Type': 'application/json' }
+      expect(WebMock).to have_requested(:post, 'http://another').with headers: { 'Content-Type': 'application/json' }
       expect(WebMock).not_to have_requested :post, 'http://default'
     end
 
     it 'delivers the message only to the default target' do
       TeamsConnector.configuration.always_use_default = true
       subject.deliver_later
 
-      expect(WebMock).to have_requested(:post, 'http://default').with headers: { "Content-Type": 'application/json' }
+      expect(WebMock).to have_requested(:post, 'http://default').with headers: { 'Content-Type': 'application/json' }
       expect(WebMock).not_to have_requested :post, 'http://localhost'
       expect(WebMock).not_to have_requested(:post, 'http://another')
     end
@@ -67,9 +67,9 @@
     it 'raises an error' do
       stub_request(:post, 'localhost').to_return(status: 400)
 
-      expect { subject.deliver_later }.to raise_error Net::HTTPServerException
+      expect { subject.deliver_later }.to raise_error Net::HTTPClientException
 
-      expect(WebMock).to have_requested(:post, 'http://localhost').with headers: { "Content-Type": 'application/json' }
+      expect(WebMock).to have_requested(:post, 'http://localhost').with headers: { 'Content-Type': 'application/json' }
       expect(WebMock).not_to have_requested :post, 'http://default'
     end
   end
@@ -107,7 +107,7 @@
     it 'delivers notifications' do
       subject.deliver_later
 
-      expect(WebMock).to have_requested(:post, 'http://localhost').with headers: { "Content-Type": 'application/json' }
+      expect(WebMock).to have_requested(:post, 'http://localhost').with headers: { 'Content-Type': 'application/json' }
       expect(WebMock).not_to have_requested :post, 'http://default'
     end
   end
@@ -147,7 +147,7 @@
     it 'falls back on bundled cards' do
       subject.deliver_later
 
-      expect(WebMock).to have_requested(:post, 'http://localhost').with headers: { "Content-Type": 'application/json' }
+      expect(WebMock).to have_requested(:post, 'http://localhost').with headers: { 'Content-Type': 'application/json' }
       expect(WebMock).not_to have_requested :post, 'http://default'
     end
   end

teams_connector.gemspec

@@ -17,6 +17,7 @@ Gem::Specification.new do |spec|
   spec.metadata['homepage_uri'] = spec.homepage
   spec.metadata['source_code_uri'] = 'https://github.com/Qurasoft/teams_connector'
   spec.metadata['changelog_uri'] = 'https://github.com/Qurasoft/teams_connector/blob/main/CHANGES.md'
+  spec.metadata['rubygems_mfa_required'] = 'true'
 
   # Specify which files should be added to the gem when it is released.
   # The `git ls-files -z` loads the files in the RubyGem that have been added into git.
@@ -26,12 +27,4 @@ Gem::Specification.new do |spec|
   spec.bindir        = 'bin'
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
-
-  spec.add_development_dependency 'bundler', '>= 1.17'
-  spec.add_development_dependency 'rake', '>= 10.0'
-  spec.add_development_dependency 'rspec', '>= 3.0'
-  spec.add_development_dependency 'rubocop'
-  spec.add_development_dependency 'sidekiq', '< 8'
-  spec.add_development_dependency 'simplecov'
-  spec.add_development_dependency 'webmock'
 end