Skip to content

Commit

Permalink
Add support for earlier Swift versions.
Browse files Browse the repository at this point in the history
  • Loading branch information
edwardbeecroft committed Jun 14, 2023
1 parent abced58 commit 9905eef
Show file tree
Hide file tree
Showing 7 changed files with 11 additions and 9 deletions.
2 changes: 2 additions & 0 deletions Examples/Examples.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -340,6 +340,7 @@
INFOPLIST_KEY_UILaunchStoryboardName = LaunchScreen;
INFOPLIST_KEY_UISupportedInterfaceOrientations_iPad = "UIInterfaceOrientationPortrait UIInterfaceOrientationPortraitUpsideDown UIInterfaceOrientationLandscapeLeft UIInterfaceOrientationLandscapeRight";
INFOPLIST_KEY_UISupportedInterfaceOrientations_iPhone = "UIInterfaceOrientationPortrait UIInterfaceOrientationLandscapeLeft UIInterfaceOrientationLandscapeRight";
IPHONEOS_DEPLOYMENT_TARGET = 13.0;
LD_RUNPATH_SEARCH_PATHS = (
"$(inherited)",
"@executable_path/Frameworks",
Expand All @@ -366,6 +367,7 @@
INFOPLIST_KEY_UILaunchStoryboardName = LaunchScreen;
INFOPLIST_KEY_UISupportedInterfaceOrientations_iPad = "UIInterfaceOrientationPortrait UIInterfaceOrientationPortraitUpsideDown UIInterfaceOrientationLandscapeLeft UIInterfaceOrientationLandscapeRight";
INFOPLIST_KEY_UISupportedInterfaceOrientations_iPhone = "UIInterfaceOrientationPortrait UIInterfaceOrientationLandscapeLeft UIInterfaceOrientationLandscapeRight";
IPHONEOS_DEPLOYMENT_TARGET = 13.0;
LD_RUNPATH_SEARCH_PATHS = (
"$(inherited)",
"@executable_path/Frameworks",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"location" : "git@github.com:QuickVerse/quickverse-ios-sdk.git",
"state" : {
"branch" : "main",
"revision" : "c53970c69c3673f60b6d21c2647c88ca1c2cfde9"
"revision" : "abced583ec177abd85ebcca3306ed394af102fae"
}
}
],
Expand Down
2 changes: 1 addition & 1 deletion QuickVerse.podspec
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Pod::Spec.new do |spec|
spec.name = "QuickVerse"
spec.version = "1.4.5"
spec.version = "1.4.6"
spec.summary = "Effortlessly integrate your quickverse.io localisations into your iOS app, for instant, over-the-air updates & more."
spec.description = <<-DESC
QuickVerse lets you translate your web and mobile apps with ease. Powered by instant, over-the-air updates, you can change your app copy anytime, anywhere.
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
[![Version](https://img.shields.io/static/v1?label=pod&message=1.4.5&color=blue&style=flat)](#cocoapods)
[![Version](https://img.shields.io/static/v1?label=pod&message=1.4.6&color=blue&style=flat)](#cocoapods)
[![SwiftPM compatible](https://img.shields.io/badge/SwiftPM-compatible-success.svg?style=flat)](#Swift-Package-Manager)
[![Carthage compatible](https://img.shields.io/badge/Carthage-compatible-success.svg?style=flat)](#carthage)
[![Twitter](https://img.shields.io/twitter/follow/quickverse_io?style=social)](https://twitter.com/quickverse_io)
Expand Down Expand Up @@ -36,7 +36,7 @@ The library should have been added to the Swift Package Dependencies section, an

```
pod 'QuickVerse' // Always use the latest version
pod 'QuickVerse', '~> 1.4.5' // Or pin to a specific version
pod 'QuickVerse', '~> 1.4.6' // Or pin to a specific version
```
2. In a terminal window, navigate to the directory of your `Podfile`, and run `pod install --repo-update`

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ extension LocalizationManager {
let request = Request(url: url, httpMethod: .get, body: nil)
apiClient.makeRequest(request: request) { [weak self] (result: Result<QuickVerseResponse, APIError>) in
guard let self else { return completion(.failure(.generic(500))) }
if case .success = result { successfulFetch = true }
if case .success = result { self.successfulFetch = true }
completion(result)
}
}
Expand Down
6 changes: 3 additions & 3 deletions Sources/QuickVerse/Internal/Managers/ReportingManager.swift
Original file line number Diff line number Diff line change
Expand Up @@ -71,13 +71,13 @@ extension ReportingManager {
guard let self else { return }
switch result {
case .success:
missingKeys.removeAll()
utilisedKeys.removeAll()
self.missingKeys.removeAll()
self.utilisedKeys.removeAll()
case .failure:
// Request failed, do not clear keys, retry on next
break
}
requestInFlight = false
self.requestInFlight = false
}
}
}
2 changes: 1 addition & 1 deletion Sources/QuickVerse/Internal/Networking/APIClient.swift
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ protocol API {

class APIClient: API {
var apiKey: String!
private let sdkVersion = "1.4.5"
private let sdkVersion = "1.4.6"

private let session: URLSession
init(session: URLSession) {
Expand Down

0 comments on commit 9905eef

Please sign in to comment.