Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for the beCloseTo and beWithin matchers #983

Merged
merged 1 commit into from
Apr 23, 2022

Conversation

younata
Copy link
Member

@younata younata commented Apr 23, 2022

Solves #888.

Updates documentation for the beCloseTo matcher to correctly state that beCloseTo expects values to conform to FloatingPoint.
Adds documentation for the beWithin matcher.

Does not add documentation for toNever (nor toAlways), because my PR adding toAlways included that documentation.

  • Does this have documentation?

@younata younata added this to the v10.0.0 milestone Apr 23, 2022
@jessesquires
Copy link
Member

@younata Is this the last thing needed for v10? 😄 🎉

Should we consider dropping old OSes and Xcodes for v10, just like Quick/Quick#1146?

Or do you think we should wait until v11?

@younata
Copy link
Member Author

younata commented Apr 23, 2022

Is this the last thing needed for v10?

Other than writing the release notes, yes. 🎉 indeed!

Should we consider dropping old OSes and Xcodes for v10, just like Quick/Quick#1146?
Or do you think we should wait until v11?

Let's wait until v11 to drop old OSes and Xcodes. That way we can ship Nimble 10 with Quick 5.1 (or a 5.1.1 release, if you want). I filed #984 to track the work of dropping support for older Xcode/OSes.

@younata younata merged commit 999e277 into Quick:main Apr 23, 2022
@younata younata deleted the update-matcher-documentation branch April 23, 2022 19:23
@jessesquires
Copy link
Member

That way we can ship Nimble 10 with Quick 5.1

Ah, perfect! 👌🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants