Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding toNever expectation #800

Merged
merged 6 commits into from
May 10, 2021
Merged

Adding toNever expectation #800

merged 6 commits into from
May 10, 2021

Conversation

rkreutz
Copy link
Contributor

@rkreutz rkreutz commented Jul 18, 2020

Adding a new expectation toNever, which will check a predicate so a value never matches that predicate. As opposed to toEventuallyNot, this expectation will fail if at some given point during the timeout interval the value matches the predicate.

  • Does this have tests? Added positive and negative matches to the new expectation
  • Does this have documentation?
  • Does this break the public API (Requires major version bump)?
  • Is this a new feature (Requires minor version bump)? Yes

@ikesyo ikesyo self-requested a review May 8, 2021 22:32
@ikesyo ikesyo self-assigned this May 9, 2021
@ikesyo ikesyo force-pushed the feature/to-never branch from 1601c05 to 013c0fc Compare May 9, 2021 09:41
@ikesyo ikesyo force-pushed the feature/to-never branch from 013c0fc to 07d6799 Compare May 9, 2021 16:52
Copy link
Member

@ikesyo ikesyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution 👏

@ikesyo ikesyo merged commit fa6c58f into Quick:master May 10, 2021
@rkreutz rkreutz deleted the feature/to-never branch May 10, 2021 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants