Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings qt3support #662

Merged
merged 91 commits into from
Feb 19, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
91 commits
Select commit Hold shift + click to select a range
1bf9d77
qucs: s/absFilePath/absoluteFilePath/
guitorri Jan 31, 2017
4318df8
qucs: s/absPath/absolutePath/
guitorri Jan 31, 2017
9b3c1e8
qucs: use correct entryList overload
guitorri Jan 31, 2017
83369cf
qucs: s/isOn/isChecked/
guitorri Jan 31, 2017
2ba905e
qucs: rewrite addTo as addAction
guitorri Jan 31, 2017
575be8b
qucs: replace QMouseEvent state by button
guitorri Jan 31, 2017
3350f9f
qucs: replace s/dirPath(true)/absolutePath()/
guitorri Jan 31, 2017
2e7abd4
qucs: replace s/dirPath()/path()/
guitorri Jan 31, 2017
11989cf
qucs: replace QComboBox insertItem by addItem
guitorri Jan 31, 2017
7760b4f
qucs: replace setCurrentItem by setCurrentIndex
guitorri Jan 31, 2017
61b8e6a
qucs: replace s/currentItem()/currentIndex()/ when possible
guitorri Jan 31, 2017
0bf86eb
qucs: replace s/currentPage/currentWidget
guitorri Jan 31, 2017
586322f
qucs: s/setOn/setChecked
guitorri Jan 31, 2017
79672e5
qucs: s/>message/>showMessage/
guitorri Jan 31, 2017
2ace871
qucs: s/insertSeparator/addSeparator/
guitorri Jan 31, 2017
1e18c5a
qucs: replace .data by .value where possible
guitorri Jan 31, 2017
4c6da82
qucs: s/lineStep/singleStep
guitorri Jan 31, 2017
8ab07bd
qucs: s/findRev/lastIndexOf
guitorri Jan 31, 2017
fe9a6ab
qucs: s/setCurrentItem/setCurrentIndex/ when possible
guitorri Jan 31, 2017
8c094fb
qucs: diagramdialog use addWidget
guitorri Jan 31, 2017
99716dc
qucs: arrowdialog use addWidget
guitorri Jan 31, 2017
1663bf5
qucs: vasettingsdialog use addWidget
guitorri Jan 31, 2017
218364e
qucs: filldialog use addWidget
guitorri Jan 31, 2017
c9bbb74
qucs: sweepdialog use addWidget, small tweaks
guitorri Jan 31, 2017
c2bf2c1
sweepdialog: add some documentation
guitorri Jan 31, 2017
00f46f0
markerdialog: port addMulti*
guitorri Jan 31, 2017
26988e2
qucs: use setCaseSensitivity
guitorri Jan 31, 2017
11f0040
qucs: s/insertItem(tr/addItem(tr/
guitorri Jan 31, 2017
cd9af7f
qucs: ComboBox use addItem
guitorri Jan 31, 2017
68da3a9
mouseactions: fix addAction context menu
guitorri Jan 31, 2017
4ab2dab
qucs: port baseName and extension
guitorri Jan 31, 2017
626653f
qucs: s/setMenuText/setText
guitorri Jan 31, 2017
4ed185f
qucs: s/.read(/.readAll(/
guitorri Jan 31, 2017
5eb3007
qucs: s/findIndex/indexOf
guitorri Jan 31, 2017
d61e137
qucs: port setPaletteBackgroundColor
guitorri Jan 31, 2017
322b342
qucs: port paletteBackgroundColor
guitorri Jan 31, 2017
1563f59
qucs: port setPaletteForegroundColor
guitorri Jan 31, 2017
58c0442
libcomp: avoid dangling else
guitorri Jan 31, 2017
1ba6267
qucs: fix drawText
guitorri Jan 31, 2017
8fe6c40
packagedialog: port readBlock and writeBlock
guitorri Jan 31, 2017
52b060f
packagedialog: port at(##)
guitorri Jan 31, 2017
ac6f192
packagedialog: fix getSaveFileName, getOpenFileName
guitorri Jan 31, 2017
08fc3a0
qucs: use toPlainText
guitorri Jan 31, 2017
4b6c662
libdialog: use fileName
guitorri Jan 31, 2017
c08dd20
libdialog: use toPlainText
guitorri Jan 31, 2017
f6959a3
libdialog: use writeRawData
guitorri Jan 31, 2017
4b6983b
spicedialog: use itemText
guitorri Jan 31, 2017
ce9dd72
qucs_actions: use read and write
guitorri Jan 31, 2017
5575498
main: use fileName
guitorri Jan 31, 2017
5cb10f9
main: drop use of .ascii
guitorri Jan 31, 2017
0a0f32a
main: use homePath
guitorri Jan 31, 2017
66c659a
main: setMainWidget no longuer needed
guitorri Jan 31, 2017
15fa444
vasettingsdial: fix getOpenFileName
guitorri Jan 31, 2017
db56b9e
qucs_init: use addPermanentWidget
guitorri Jan 31, 2017
36864be
changedialog: port remainig issues
guitorri Jan 31, 2017
8ae812c
sweepdialog: use setColumnStretch
guitorri Jan 31, 2017
b42411e
savedial: use erase
guitorri Jan 31, 2017
9ba4713
components: use split correctly
guitorri Jan 31, 2017
1d4bc33
digisett: fix addButton and split
guitorri Jan 31, 2017
812e2ba
printer: fix use of Aborted
guitorri Jan 31, 2017
f066020
misc: fix use of split
guitorri Jan 31, 2017
5773893
actions: use setPointSizeF
guitorri Jan 31, 2017
2d26d31
qucsdoc: fix addAction
guitorri Feb 1, 2017
cd44439
qucs_actions: replace reparent
guitorri Feb 1, 2017
b960b9f
main: replace locale
guitorri Feb 1, 2017
a57a9ee
octave_win: convert Qstring to char *
guitorri Feb 1, 2017
9ba9770
qucs_init: fix messed up tr strings
guitorri Feb 1, 2017
bddd3b6
qucs: convert Qstring to char *
guitorri Feb 1, 2017
b4318ab
printer: update to setOptions
guitorri Feb 1, 2017
a6301de
qucs-help: update setVisible
guitorri Feb 1, 2017
5c9bce4
cmake: add -DQT_DEPRECATED_WARNINGS
guitorri Feb 2, 2017
33d8439
fix s/convertSeparators/toNativeSeparators
guitorri Feb 2, 2017
3b9a60b
autotools: add -DQT_DEPRECATED_WARNINGS
guitorri Feb 2, 2017
b6602a5
autotools:mac: add warning flags
guitorri Feb 2, 2017
c6b571c
qucs: s/convertSeparators/toNativeSeparators/
guitorri Feb 6, 2017
d7cb399
qucs_init: remove setCheckable
guitorri Feb 7, 2017
34e0bf5
ArrowDialog: fix deprecated QDialog signature
guitorri Feb 7, 2017
39fe896
savedialog: fix QDialog
guitorri Feb 7, 2017
c0a9086
markerdialog: fix QDialog
guitorri Feb 7, 2017
fba408b
diagramdialog: fix QDialog
guitorri Feb 7, 2017
ceb8b8f
spicedialog: fix QDialog
guitorri Feb 7, 2017
c799024
graphicstextdialog: fix QDialog
guitorri Feb 7, 2017
c85be24
diagramdialog: fix QSlider
guitorri Feb 7, 2017
9302d90
diagramdialog: fix QGridLayout
guitorri Feb 8, 2017
9a29ba6
arrowdialog: fix QGridLayout
guitorri Feb 8, 2017
14e8c21
filldialog: fix QGridLayout
guitorri Feb 8, 2017
2e9f7d1
savedialog: fix V and H layout
guitorri Feb 8, 2017
2ff0313
mouseactions: fix QMouseEvent
guitorri Feb 8, 2017
107ecc0
qucs: fix argc() and argv()
guitorri Feb 8, 2017
ecba220
spicedialog: fix QMessageBox
guitorri Feb 8, 2017
0c8ef46
simmessage: fix toAscii
guitorri Feb 8, 2017
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion qucs/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,8 @@ SET( QT_DEBUG TRUE)

INCLUDE( ${QT_USE_FILE} )

ADD_DEFINITIONS(${QT_DEFINITIONS})
ADD_DEFINITIONS(${QT_DEFINITIONS} -DQT_DEPRECATED_WARNINGS)


ADD_SUBDIRECTORY( qucs )
ADD_SUBDIRECTORY( qucs-activefilter )
Expand Down
4 changes: 2 additions & 2 deletions qucs/configure.ac
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,7 @@ case $host_os in
if test "$enable_mt" = yes; then
QT_LDF=""
QT_LIB="-lQtCore -lQtGui -lQtXml -lQt3Support -lQtSvg -lQtScript"
QT_INC="$QT_DEF -DQT3_SUPPORT -DQT3_SUPPORT_WARNINGS -DQT_THREAD_SUPPORT -D_REENTRANT"
QT_INC="$QT_DEF -DQT3_SUPPORT -DQT3_SUPPORT_WARNINGS -DQT_DEPRECATED_WARNINGS -DQT_THREAD_SUPPORT -D_REENTRANT"
[case $host_os in
*freebsd*) QT_LIB="$QT_LIB -pthread" ;;
*mingw* | *msys*) QT_INC="$QT_INC -mthreads"; QT_LDF="$QT_LDF -mthreads" ;;
Expand Down Expand Up @@ -412,7 +412,7 @@ case $host_os in
fi

dnl Define Qt3Support
QT_DEF="-DQT_SHARED -DQT3_SUPPORT"
QT_DEF="-DQT_SHARED -DQT3_SUPPORT -DQT3_SUPPORT_WARNINGS -DQT_DEPRECATED_WARNINGS"
CPPFLAGS="$CPPFLAGS $QT_DEF"
QT_LDFLAGS="$QT_LDFLAGS -headerpad_max_install_names"

Expand Down
2 changes: 1 addition & 1 deletion qucs/qucs-activefilter/main.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ int main(int argc, char *argv[])
QucsDir = QDir (var);
QString QucsDirStr = QucsDir.canonicalPath ();
LangDir =
QDir::convertSeparators (QucsDirStr + "/share/qucs/lang/");
QDir::toNativeSeparators(QucsDirStr + "/share/qucs/lang/");
} else {
QString QucsApplicationPath = QCoreApplication::applicationDirPath();
#ifdef __APPLE__
Expand Down
2 changes: 1 addition & 1 deletion qucs/qucs-attenuator/main.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ int main( int argc, char ** argv )
QucsDir = QDir (var);
QString QucsDirStr = QucsDir.canonicalPath ();
QucsSettings.LangDir =
QDir::convertSeparators (QucsDirStr + "/share/qucs/lang/");
QDir::toNativeSeparators(QucsDirStr + "/share/qucs/lang/");
} else {
QString QucsApplicationPath = QCoreApplication::applicationDirPath();
#ifdef __APPLE__
Expand Down
2 changes: 1 addition & 1 deletion qucs/qucs-edit/main.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ int main(int argc, char *argv[])
QucsDir = QDir (var);
QString QucsDirStr = QucsDir.canonicalPath ();
QucsSettings.LangDir =
QDir::convertSeparators (QucsDirStr + "/share/qucs/lang/");
QDir::toNativeSeparators(QucsDirStr + "/share/qucs/lang/");
} else {
QString QucsApplicationPath = QCoreApplication::applicationDirPath();
#ifdef __APPLE__
Expand Down
2 changes: 1 addition & 1 deletion qucs/qucs-filter-v2/qf_main.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ int main (int argc, char * argv []) {
QucsDir = QDir (var);
QString QucsDirStr = QucsDir.canonicalPath ();
QucsSettings.LangDir =
QDir::convertSeparators (QucsDirStr + "/share/qucs/lang/");
QDir::toNativeSeparators (QucsDirStr + "/share/qucs/lang/");
} else {
QString QucsApplicationPath = QCoreApplication::applicationDirPath();
#ifdef __APPLE__
Expand Down
10 changes: 5 additions & 5 deletions qucs/qucs-filter-v2/qf_settings.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ bool loadSettings (void)
{
bool result = true;

QFile file(QDir::homeDirPath()+QDir::convertSeparators ("/.qucs/filterrc"));
QFile file(QDir::homeDirPath()+QDir::toNativeSeparators ("/.qucs/filterrc"));
if(!file.open(QIODevice::ReadOnly))
result = false; // settings file doesn't exist
else {
Expand All @@ -56,7 +56,7 @@ bool loadSettings (void)
file.close();
}

file.setName(QDir::homeDirPath()+QDir::convertSeparators ("/.qucs/qucsrc"));
file.setName(QDir::homeDirPath()+QDir::toNativeSeparators ("/.qucs/qucsrc"));
if(!file.open(QIODevice::ReadOnly))
result = true; // qucs settings not necessary
else {
Expand Down Expand Up @@ -85,7 +85,7 @@ bool saveSettings(qf_box *qucs)
return true; // nothing has changed


QFile file(QDir::homeDirPath()+QDir::convertSeparators ("/.qucs/filterrc"));
QFile file(QDir::homeDirPath()+QDir::toNativeSeparators ("/.qucs/filterrc"));
if(!file.open(QIODevice::WriteOnly)) {
QMessageBox::warning(0, QObject::tr("Warning"),
QObject::tr("Cannot save settings !"));
Expand Down Expand Up @@ -156,7 +156,7 @@ bool saveXmlSettings (qf_box * qucs)
gr.appendChild (el);
rt.appendChild (gr);

QFile file (QDir::homeDirPath()+QDir::convertSeparators ("/.qucs/filterrc"));
QFile file (QDir::homeDirPath()+QDir::toNativeSeparators ("/.qucs/filterrc"));
if (!file.open (QIODevice::WriteOnly)) {
QMessageBox::warning (0,
QObject::tr("Warning"),
Expand Down Expand Up @@ -230,7 +230,7 @@ bool loadXmlSettings (void)
{
bool result = true;

QFile file (QDir::homeDirPath()+QDir::convertSeparators ("/.qucs/filterrc"));
QFile file (QDir::homeDirPath()+QDir::toNativeSeparators ("/.qucs/filterrc"));
if (!file.open(QIODevice::ReadOnly))
result = false; // settings file doesn't exist
else {
Expand Down
2 changes: 1 addition & 1 deletion qucs/qucs-filter/main.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ int main(int argc, char *argv[])
QucsDir = QDir (var);
QString QucsDirStr = QucsDir.canonicalPath ();
QucsSettings.LangDir =
QDir::convertSeparators (QucsDirStr + "/share/qucs/lang/");
QDir::toNativeSeparators(QucsDirStr + "/share/qucs/lang/");
} else {
QString QucsApplicationPath = QCoreApplication::applicationDirPath();
#ifdef __APPLE__
Expand Down
4 changes: 2 additions & 2 deletions qucs/qucs-help/main.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -138,9 +138,9 @@ int main(int argc, char *argv[])
QucsDir = QDir (QString(var));
QString QucsDirStr = QucsDir.canonicalPath ();
QucsSettings.DocDir =
QDir::convertSeparators (QucsDirStr + "/share/qucs/docs/");
QDir::toNativeSeparators(QucsDirStr + "/share/qucs/docs/");
QucsSettings.LangDir =
QDir::convertSeparators (QucsDirStr + "/share/qucs/lang/");
QDir::toNativeSeparators(QucsDirStr + "/share/qucs/lang/");
} else {
QString QucsApplicationPath = QCoreApplication::applicationDirPath();
#ifdef __APPLE__
Expand Down
2 changes: 1 addition & 1 deletion qucs/qucs-help/qucshelp.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ void QucsHelp::nextLink()

void QucsHelp::slotToggleSidebar(bool b)
{
dock->setShown(b);
dock->setVisible(b);
}

void QucsHelp::slotToggleSidebarAction(bool b)
Expand Down
2 changes: 1 addition & 1 deletion qucs/qucs-transcalc/main.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ int main(int argc, char *argv[])
QucsDir = QDir (var);
QString QucsDirStr = QucsDir.canonicalPath ();
QucsSettings.LangDir =
QDir::convertSeparators (QucsDirStr + "/share/qucs/lang/");
QDir::toNativeSeparators(QucsDirStr + "/share/qucs/lang/");
} else {
QString QucsApplicationPath = QCoreApplication::applicationDirPath();
#ifdef __APPLE__
Expand Down
4 changes: 2 additions & 2 deletions qucs/qucs-transcalc/qucstrans.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1046,7 +1046,7 @@ void QucsTranscalc::slotValueChanged()

// Load transmission line values from the given file.
bool QucsTranscalc::loadFile(QString fname, int * _mode) {
QFile file(QDir::convertSeparators (fname));
QFile file(QDir::toNativeSeparators(fname));
if(!file.open(QIODevice::ReadOnly)) return false; // file doesn't exist

QTextStream stream(&file);
Expand Down Expand Up @@ -1088,7 +1088,7 @@ bool QucsTranscalc::loadFile(QString fname, int * _mode) {

// Saves current transmission line values into the given file.
bool QucsTranscalc::saveFile(QString fname) {
QFile file (QDir::convertSeparators (fname));
QFile file (QDir::toNativeSeparators(fname));
if(!file.open (QIODevice::WriteOnly)) return false; // file not writable
QTextStream stream (&file);

Expand Down
2 changes: 1 addition & 1 deletion qucs/qucs/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ IF(WIN32)
ENDIF()
ENDIF(WIN32)

ADD_DEFINITIONS(${QT_DEFINITIONS})
ADD_DEFINITIONS(${QT_DEFINITIONS} -DQT3_SUPPORT_WARNINGS)

INCLUDE_DIRECTORIES(
${qucs_SOURCE_DIR}
Expand Down
2 changes: 1 addition & 1 deletion qucs/qucs/components/ac_sim.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ AC_Sim::AC_Sim()

QString s = Description;
int a = s.indexOf(" ");
int b = s.findRev(" ");
int b = s.lastIndexOf(" ");
if (a != -1 && b != -1) {
if (a > (int) s.length() - b) b = a;
}
Expand Down
2 changes: 1 addition & 1 deletion qucs/qucs/components/componentdialog.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1123,7 +1123,7 @@ void ComponentDialog::slotBrowseFile()
edit->setText(s);
}
/* FIX
prop->currentItem()->setText(1, s); */
prop->currentIndex()->setText(1, s); */
}

// -------------------------------------------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion qucs/qucs/components/dc_sim.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ DC_Sim::DC_Sim()

QString s = Description;
int a = s.indexOf(" ");
int b = s.findRev(" ");
int b = s.lastIndexOf(" ");
if (a != -1 && b != -1) {
if (a > (int) s.length() - b) b = a;
}
Expand Down
2 changes: 1 addition & 1 deletion qucs/qucs/components/hb_sim.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ HB_Sim::HB_Sim()
Description = QObject::tr("Harmonic balance simulation");

QString s = Description;
int a = s.findRev(" ");
int a = s.lastIndexOf(" ");
if (a != -1) s[a] = '\n'; // break line before the word "simulation"

Texts.append(new Text(0, 0, s.left(a), Qt::darkBlue, QucsSettings.largeFontSize));
Expand Down
15 changes: 8 additions & 7 deletions qucs/qucs/components/libcomp.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -86,14 +86,14 @@ int LibComp::loadSection(const QString& Name, QString& Section,
QStringList *Includes)
{
QDir Directory(QucsSettings.LibDir);
QFile file(Directory.absFilePath(Props.first()->Value + ".lib"));
QFile file(Directory.absoluteFilePath(Props.first()->Value + ".lib"));
if(!file.open(QIODevice::ReadOnly))
return -1;

QString libDefaultSymbol;

QTextStream ReadWhole(&file);
Section = ReadWhole.read();
Section = ReadWhole.readAll();
file.close();


Expand Down Expand Up @@ -140,7 +140,7 @@ int LibComp::loadSection(const QString& Name, QString& Section,
if(EndI < 0) return -11; // file corrupt
StartI++; EndI--;
QString inc = Section.mid(StartI, EndI-StartI);
QStringList f = QStringList::split(QRegExp("\"\\s+\""), inc);
QStringList f = inc.split(QRegExp("\"\\s+\""));
for(QStringList::Iterator it = f.begin(); it != f.end(); ++it ) {
Includes->append(*it);
}
Expand All @@ -149,14 +149,15 @@ int LibComp::loadSection(const QString& Name, QString& Section,

// search model
Start = Section.indexOf("<"+Name+">");
if(Start < 0)
if(Start < 0) {
if((Name == "Symbol") && (~libDefaultSymbol.isEmpty())) {
// component does not define its own symbol but the library defines a default symbol
Section = libDefaultSymbol;
return 0;
} else {
return -7; // symbol not found
}
}
Start = Section.indexOf('\n', Start);
if(Start < 0) return -8; // file corrupt
while(Section.at(++Start) == ' ') ;
Expand Down Expand Up @@ -222,7 +223,7 @@ int LibComp::loadSymbol()
QString LibComp::getSubcircuitFile()
{
QDir Directory(QucsSettings.LibDir);
QString FileName = Directory.absFilePath(Props.first()->Value);
QString FileName = Directory.absoluteFilePath(Props.first()->Value);
return misc::properAbsFileName(FileName);
}

Expand All @@ -247,7 +248,7 @@ bool LibComp::createSubNetlist(QTextStream *stream, QStringList &FileList,
for(QStringList::Iterator it = Includes.begin();
it != Includes.end(); ++it ) {
QString s = getSubcircuitFile()+"/"+*it;
if(FileList.findIndex(s) >= 0) continue;
if(FileList.indexOf(s) >= 0) continue;
FileList.append(s);

// load file and stuff into stream
Expand All @@ -257,7 +258,7 @@ bool LibComp::createSubNetlist(QTextStream *stream, QStringList &FileList,
} else {
QByteArray FileContent = file.readAll();
file.close();
//?stream->writeRawBytes(FileContent.data(), FileContent.size());
//?stream->writeRawBytes(FileContent.value(), FileContent.size());
(*stream) << FileContent.data();
qDebug() << "hi from libcomp";
}
Expand Down
2 changes: 1 addition & 1 deletion qucs/qucs/components/opt_sim.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ bool Optimize_Sim::loadASCOout()
while(!instream.atEnd()) Line = instream.readLine();
infile.close();

QStringList entries = QStringList::split(':',Line);
QStringList entries = Line.split(':');
QStringList::Iterator it;
for(it = entries.begin(); it != entries.end(); ++it ) {
QString Name = *it;
Expand Down
2 changes: 1 addition & 1 deletion qucs/qucs/components/param_sweep.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ Param_Sweep::Param_Sweep()
Description = QObject::tr("Parameter sweep");

QString s = Description;
int a = s.findRev(" ");
int a = s.lastIndexOf(" ");
if (a != -1) s[a] = '\n'; // break line

Texts.append(new Text(0, 0, s.left(a), Qt::darkBlue, QucsSettings.largeFontSize));
Expand Down
2 changes: 1 addition & 1 deletion qucs/qucs/components/sp_sim.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ SP_Sim::SP_Sim()

QString s = Description;
int a = s.indexOf(" ");
int b = s.findRev(" ");
int b = s.lastIndexOf(" ");
if (a != -1 && b != -1) {
if (a > (int) s.length() - b) b = a;
}
Expand Down
33 changes: 17 additions & 16 deletions qucs/qucs/components/spicedialog.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@


SpiceDialog::SpiceDialog(QucsApp* App_, SpiceFile *c, Schematic *d)
: QDialog(d, 0, TRUE, Qt::WDestructiveClose)
: QDialog(d, Qt::WDestructiveClose)
{
App = App_; // pointer to main application

Expand Down Expand Up @@ -161,9 +161,9 @@ SpiceDialog::SpiceDialog(QucsApp* App_, SpiceFile *c, Schematic *d)
SimCheck->setChecked(Comp->Props.at(2)->Value == "yes");
for(int i=0; i<PrepCombo->count(); i++)
{
if(PrepCombo->text(i) == Comp->Props.at(3)->Value)
if(PrepCombo->itemText(i) == Comp->Props.at(3)->Value)
{
PrepCombo->setCurrentItem(i);
PrepCombo->setCurrentIndex(i);
currentPrep = i;
break;
}
Expand Down Expand Up @@ -288,11 +288,11 @@ void SpiceDialog::slotButtBrowse()
}

QFileInfo Info(s);
lastDir = Info.dirPath(true); // remember last directory
lastDir = Info.absolutePath(); // remember last directory

// snip path if file in current directory
if(QucsSettings.QucsWorkDir.exists(Info.fileName()) &&
QucsSettings.QucsWorkDir.absPath() == Info.dirPath(true)) {
QucsSettings.QucsWorkDir.absolutePath() == Info.absolutePath()) {
s = Info.fileName();
}
FileEdit->setText(s);
Expand All @@ -307,7 +307,7 @@ void SpiceDialog::slotPrepChanged(int i)
if(currentPrep != i)
{
currentPrep = i;
PrepCombo->setCurrentItem(i);
PrepCombo->setCurrentIndex(i);
loadSpiceNetList(FileEdit->text()); // reload netlist nodes
}
}
Expand Down Expand Up @@ -371,11 +371,12 @@ bool SpiceDialog::loadSpiceNetList(const QString& s)
connect(SpicePrep, SIGNAL(readyReadStandardError()), SLOT(slotGetPrepErr()));
}

QMessageBox *MBox = new QMessageBox(tr("Info"),
QMessageBox *MBox = new QMessageBox(QMessageBox::NoIcon,
tr("Info"),
tr("Preprocessing SPICE file \"%1\".").arg(FileInfo.filePath()),
QMessageBox::NoIcon, QMessageBox::Abort,
QMessageBox::NoButton, QMessageBox::NoButton, this, 0, true,
Qt::WStyle_DialogBorder | Qt::WDestructiveClose);
QMessageBox::Abort,
this);
MBox->setAttribute(Qt::WA_DeleteOnClose);

connect(SpicePrep, SIGNAL(finished(int, QProcess::ExitStatus)), MBox, SLOT(close()));

Expand Down Expand Up @@ -438,12 +439,12 @@ bool SpiceDialog::loadSpiceNetList(const QString& s)
connect(QucsConv, SIGNAL(readyReadStandardError()), SLOT(slotGetError()));


QMessageBox *MBox = new QMessageBox(tr("Info"),
QMessageBox *MBox = new QMessageBox(QMessageBox::NoIcon,
tr("Info"),
tr("Converting SPICE file \"%1\".").arg(FileInfo.filePath()),
QMessageBox::NoIcon, QMessageBox::Abort,
QMessageBox::NoButton, QMessageBox::NoButton, this, 0, true,
Qt::WStyle_DialogBorder | Qt::WDestructiveClose);

QMessageBox::Abort,
this);
MBox->setAttribute(Qt::WA_DeleteOnClose);
connect(QucsConv, SIGNAL(finished(int, QProcess::ExitStatus)), MBox, SLOT(close()));

QucsConv->start(Program, Arguments);
Expand All @@ -465,7 +466,7 @@ bool SpiceDialog::loadSpiceNetList(const QString& s)
if(!pp->Value.isEmpty())
{
PortsList->clear();
QStringList ports = QStringList::split(',', pp->Value);
QStringList ports = pp->Value.split(',');
foreach(QString port, ports) {
PortsList->addItem(port);
}
Expand Down
Loading