Fix for #615 #616
Merged
Fix for #615 #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
guitorri
reviewed
Nov 24, 2016
| @@ -156,6 +156,16 @@ int ImageWriter::print(QWidget *doc) | |||
| if (dlg->exec()) { | |||
| QString filename = dlg->FileToSave(); | |||
| lastExportFilename = filename; | |||
| if (QFile::exists(filename)) { | |||
| int r = QMessageBox::question(0,QObject::tr("Export as image"), | |||
| QObject::tr("File already exists." | |||
There was a problem hiding this comment.
Need a space or line break here.
Perhaps reuse the already translated strings from
https://github.com/Qucs/qucs/blob/release-0.0.19/qucs/qucs/qucs_actions.cpp#L923
There was a problem hiding this comment.
I replaced messages by already translated from the qucs_actions.
in3otd
reviewed
Nov 25, 2016
| @@ -156,6 +156,16 @@ int ImageWriter::print(QWidget *doc) | |||
| if (dlg->exec()) { | |||
| QString filename = dlg->FileToSave(); | |||
| lastExportFilename = filename; | |||
There was a problem hiding this comment.
nit-picking/question: should the lastExportFilename be updated only if actually used successfully, i.e. move the assignment after the if (r == QMessageBox::No) check?
Yes, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is fix for #615. Added a dialog when image file to export already exists. It will preserve image file form automatic overwriting.