Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup Component::save and ::load #383

Merged
merged 7 commits into from
Oct 6, 2017
Merged

cleanup Component::save and ::load #383

merged 7 commits into from
Oct 6, 2017

Conversation

felix-salfelder
Copy link
Member

this is a no-op in preparation of

  • implement different schematic formats (verilog, XML, qucsch)
  • implement symbol attributes properly

@ra3xdh
Copy link
Contributor

ra3xdh commented Sep 26, 2015

Merging of this PR could be considered only after release, because it concerns core qucs-gui classes concept. As far I can understand you moved save() method from Component class to Schematic class. It will result in further bloating of Schematic code that is not good.

@felix-salfelder
Copy link
Member Author

read my patch. i clearly state, that this is a transitional commit, and that schematic serialization is meant to be implemented as part of a class derived from SchematicSerializer. this is where it belongs. it has absolutely nothing to do with Component.

i do not see your problem, with a concept. there is absolutely no concept for multiple ways of dumping the schematic, exept some stale preprocessor directives related to XML.

(please either let me do the cleanup or propose a better way, we had that.)

@felix-salfelder felix-salfelder force-pushed the schematic_cleanup branch 3 times, most recently from 842bf40 to f14e475 Compare September 27, 2015 21:49
@felix-salfelder
Component::save cleanup
248837f 
a Component (which is actually a symbol) is not language dependent,
hence it must not implement "save".

code now stashed in Schematic::saveComponent. will later move to an
instance of virtual void SchematicSerializer::saveComponent.
@felix-salfelder
Component::load cleanup
f14e475 
A Component is language independent, hence it is the wrong class to
host "load" (which is language dependent).

this is a no-op. staging for inclusion into a SchematicParser.
@felix-salfelder
Copy link
Member Author

another cleanup done...

@felix-salfelder felix-salfelder changed the title cleanup Component::save cleanup Component::save and ::load Sep 28, 2015
@felix-salfelder felix-salfelder mentioned this pull request Oct 1, 2015
Closed
@felix-salfelder felix-salfelder added this to the 0.0.20 milestone Feb 6, 2016
@felix-salfelder
Copy link
Member Author

ready for go ('develop')...

@felix-salfelder felix-salfelder mentioned this pull request Jul 23, 2016
Closed
@in3otd in3otd mentioned this pull request Jul 24, 2016
Merged
@felix-salfelder felix-salfelder mentioned this pull request Aug 18, 2016
Closed
@felix-salfelder felix-salfelder changed the base branch from master to develop November 4, 2016 17:18
@felix-salfelder
Copy link
Member Author

felix-salfelder commented Feb 1, 2017 •
edited
Loading

please merge (into develop). this is required as a basis for proper symbol attributes, and loadable symbol support.

@guitorri guitorri self-requested a review October 6, 2017 10:19
@guitorri
Copy link
Member

guitorri commented Oct 6, 2017

Looks good to me. Merging.

@guitorri guitorri merged commit 17d77cf into Qucs:develop Oct 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guitorri guitorri Awaiting requested review from guitorri

Assignees
No one assigned
Labels
qucs-gui refactor
Projects
None yet
Milestone
0.0.20
Development

Successfully merging this pull request may close these issues.
3 participants
@felix-salfelder @ra3xdh @guitorri