-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
264 reserved header include guard #268
Conversation
89f50da
to
8e47d6a
Compare
Some headers are quite generic ( |
makes sense anyway... I saw around that some proposes to use macro names like PROJECT_DIR_HEADERNAME so we will have something like |
Perhaps just |
yes, just (Somewhat unrelated, maybe one day we should also change the |
Header include guards started with undercore are reserved to the implementation. Fixing for the sake of good practice Spotted by Markus Elfring. See issue Qucs#264.
This is just a convention. Doesn't hurt to be consistent.
Just for consistency.
8e47d6a
to
cbb8aad
Compare
Rebased. |
hmm, any reason, we should not switch header guards to |
Didn't know about it. |
yes, there may be pitfalls (that were not entirely clear to me). iirc, we had once fixed output filenames, to get |
Most of this is Qucsator (it needs rebase). The other bits seem obsolete, as most plugins don't need header guards. |
Fix all header include guards. The leading underscore is reserved to the C++ implementation. Uppercase is a common convention. This closes issue #264.