Skip to content

Commit

Permalink
Remove splitting of paint routines
Browse files Browse the repository at this point in the history
between paintDiagram() and paintMarker() that was introduced to
handle marker hiding during printing.
This is now handled differently (see previous commit) so there can be
just a single paint() routine now.
  • Loading branch information
in3otd authored and felix-salfelder committed Jul 16, 2018
1 parent 30e5fa6 commit 4764972
Show file tree
Hide file tree
Showing 6 changed files with 2 additions and 26 deletions.
9 changes: 0 additions & 9 deletions qucs/qucs/diagrams/diagram.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -99,12 +99,6 @@ Diagram::~Diagram()
Paint function for few diagrams (cartesian, smith, polar, ...)
*/
void Diagram::paint(ViewPainter *p)
{
paintDiagram(p);
paintMarkers(p);
}

void Diagram::paintDiagram(ViewPainter *p)
{
// paint all lines
foreach(Line *pl, Lines) {
Expand Down Expand Up @@ -159,10 +153,7 @@ void Diagram::paintDiagram(ViewPainter *p)
p->drawResizeRect(cx+x2, cy-y2);
p->drawResizeRect(cx+x2, cy);
}
}

void Diagram::paintMarkers(ViewPainter *p)
{
// draw markers last, so they are at the top of painting layers
foreach(Graph *pg, Graphs)
foreach(Marker *pm, pg->Markers)
Expand Down
3 changes: 0 additions & 3 deletions qucs/qucs/diagrams/diagram.h
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,6 @@ class Diagram : public Element {
virtual QString extraMarkerText(Marker const*) const {return "";}

virtual void paint(ViewPainter*);
protected: // strictly internal
virtual void paintDiagram(ViewPainter* p);
void paintMarkers(ViewPainter* p);
public:
void setCenter(int, int, bool relative=false);
void getCenter(int&, int&);
Expand Down
7 changes: 1 addition & 6 deletions qucs/qucs/diagrams/tabdiagram.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -46,13 +46,8 @@ TabDiagram::~TabDiagram()
{
}

void TabDiagram::paint(ViewPainter *p)
{
paintDiagram(p);
}

// ------------------------------------------------------------
void TabDiagram::paintDiagram(ViewPainter *p)
void TabDiagram::paint(ViewPainter *p)
{
// paint all lines
foreach(Line *pl, Lines) {
Expand Down
1 change: 0 additions & 1 deletion qucs/qucs/diagrams/tabdiagram.h
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ class TabDiagram : public Diagram {
virtual Diagram* newOne();
static Element* info(QString&, char* &, bool getNewOne=false);
virtual void paint(ViewPainter*);
virtual void paintDiagram(ViewPainter *p);
virtual int calcDiagram();
virtual int scroll(int);
virtual bool scrollTo(int, int, int);
Expand Down
7 changes: 1 addition & 6 deletions qucs/qucs/diagrams/timingdiagram.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -45,13 +45,8 @@ TimingDiagram::~TimingDiagram()
{
}

void TimingDiagram::paint(ViewPainter *p)
{
paintDiagram(p);
}

// ------------------------------------------------------------
void TimingDiagram::paintDiagram(ViewPainter *p)
void TimingDiagram::paint(ViewPainter *p)
{
// paint all lines
foreach(Line *pl, Lines) {
Expand Down
1 change: 0 additions & 1 deletion qucs/qucs/diagrams/timingdiagram.h
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ class TimingDiagram : public TabDiagram {
Diagram* newOne();
static Element* info(QString&, char* &, bool getNewOne=false);
void paint(ViewPainter *p);
void paintDiagram(ViewPainter *p);
int calcDiagram();
int scroll(int);
bool scrollTo(int, int, int);
Expand Down

0 comments on commit 4764972

Please sign in to comment.