[consensus] Add check block in consensus #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ninjaahhh
suggested changes
Aug 20, 2020
|
invalid check block response includes following scenarios
|
|
we also need to figure out the timeout mechanism for prevote - since |
Codecov Report
@@ Coverage Diff @@
## master #46 +/- ##
==========================================
+ Coverage 60.82% 61.32% +0.50%
==========================================
Files 269 271 +2
Lines 28290 28508 +218
==========================================
+ Hits 17206 17483 +277
+ Misses 9576 9516 -60
- Partials 1508 1509 +1
|
ninjaahhh
reviewed
Aug 26, 2020
state/validation.go
Outdated
| @@ -62,12 +62,6 @@ func validateBlock(evidencePool EvidencePool, stateDB dbm.DB, state State, block | |||
| block.ConsensusHash, | |||
| ) | |||
| } | |||
| if !bytes.Equal(block.LastResultsHash, state.LastResultsHash) { | |||
There was a problem hiding this comment.
thinking about this change, I suggest we do another dedicate PR to remove those checks and make this PR only about CheckBlock
ninjaahhh
reviewed
Aug 27, 2020
ninjaahhh
reviewed
Aug 31, 2020
abcix/example/kvstore/kvstore.go
Outdated
| }, | ||
| }, | ||
| } | ||
| events := []types.Event{} | ||
| return types.ResponseCreateBlock{Txs: txs, InvalidTxs: invalidTxs, Hash: appHash, Events: events} |
abcix/example/kvstore/kvstore.go
Outdated
| txResp := types.ResponseDeliverTx{GasUsed: gasUsed} | ||
| ret.DeliverTxs = append(ret.DeliverTxs, &txResp) | ||
| } | ||
| ret.AppHash = lastState.AppHash |
There was a problem hiding this comment.
should add a nil check. if no txs, lastState will be nil pointer
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
ninjaahhh
approved these changes
Sep 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CheckBlock is called after a proposed block is received and before prevote.
part 2/3 for #26