Added Testing for 3to1 purification #29

Barosandu · 2023-08-10T14:20:46Z

No description provided.

codecov · 2023-08-10T14:36:42Z

Codecov Report

Merging #29 (c1e2947) into master (b0ab270) will decrease coverage by 0.17%.
The diff coverage is 67.01%.

@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
- Coverage   67.80%   67.63%   -0.17%     
==========================================
  Files          23       23              
  Lines         702      893     +191     
==========================================
+ Hits          476      604     +128     
- Misses        226      289      +63

Files Changed	Coverage Δ
src/CircuitZoo/CircuitZoo.jl	`71.62% <67.01%> (-28.38%)`	⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Krastanov · 2023-08-16T13:00:15Z

test/test_circuitzoo_purification.jl

+        for i in 1:13
+            initialize!(r[(2*i-1):(2*i)], bell)
+        end
+        @test PurifyStringent()(r[1], r[2],


Probably a bit simpler to do with (r[1:26]...) instead of giving each slot separately.

When i do this the whole library gets kill signal because of the lack of ram.

Oh, interesting, that is certainly a bug that should be fixed with the base library. Could you file an issue for it?

There is another quick fix: use the Clifford representation instead of state vectors. Kets and density matrices are exponentially expensive (as you have observed), but a Clifford tableaux simulation should be much cheaper and faster (even if it can not simulate all the types of dynamics that a ket-style simulation can)

But there seems to be a problem when measuring the fidelity. It only works in QuantumOpticsRepr else it yields an error.

Expression: abs(observable(r[1:2], projector(bell))) >= rnd
DomainError with Only pure (not mixed) states are supported when calculating inner product.:

Krastanov · 2023-08-16T13:01:01Z

test/test_circuitzoo_purification.jl

+                apply!(r[target], Dict(:X=>X, :Y=>Y, :Z=>Z)[error])
+                @test Purify3to1(fixtwice)(r[1], r[2], [r[3], r[5]], [r[4], r[6]])==false
+            end
+            ## When [error, fixtwice] in {[X,Z], [Z,Y], [Y,X]} it yields true is that supposed to happen?


Could you elaborate, what does that mean?

Well apparently it does not detect the error when [error, fixtwice] are in {[X,Z], [Z,Y], [Y,X]}. It seems a quite consistent behaviour and i think it's supposed to happen but i dont seem to figure out why

This is in the 3to1 circuit, right?

We looked at a couple of versions of the 3to1 circuit. Some that can easily be split into two 2to1 circuits, where pair 3 is sacrificed to purify pair 2, which is sacrificed to purify pair 1. But there are also 3to1 circuits which can not be split neatly like into separate subcircuit -- all pair have gates between them before measurements can start. You observed that both of these styles of circuits have the same performance if the gates are perfect. That had confused me at first -- because the non-factorable circuits are known to be able to fight also gate errors.

Could you try to run that simulation? One in which gate errors also happen. That would let us know whether we are missing some better circuits.

I ran it and the double selection circuits do have better fidelity then the ordered ones.
The notebook is in a repo in my profile

https://github.com/Barosandu/JLNotebookQuantum

Barosandu · 2023-08-22T10:28:36Z

Can you provide some feedback on testing?

Krastanov · 2023-08-22T13:17:56Z

@Barosandu , left in two comments that I hope are helpful. One is for how to make it a bit faster to run some of the simulations (by sticking to only quantumclifford.jl representation), one about reporting as a bug some of the issues you uncovered, and one about verifying the 3to1 circuits are the ones we want.

Barosandu · 2023-08-23T13:52:27Z

@Krastanov i committed the final touches. Please review :)

Krastanov · 2023-08-24T06:47:24Z

src/CircuitZoo/CircuitZoo.jl

@@ -132,4 +132,431 @@ function (circuit::Purify2to1)(purifiedL,purifiedR,sacrificedL,sacrificedR)
    success
 end

+struct Purify2to1Left <: AbstractCircuit


could you:

add a detailed docstring for this circuit, including tests

rename it to Purify2to1Node (otherwise folks will be wondering where is the Right one)

Krastanov · 2023-08-24T06:48:13Z

src/CircuitZoo/CircuitZoo.jl

+    leaveout::Symbol
+    function Purify2to1Left(leaveout)
+        if leaveout ∉ (:X, :Y, :Z)
+            throw(ArgumentError(lazy"""


could you add a @test_throws in the tests so this line is also tested?

Krastanov · 2023-08-24T06:48:59Z

src/CircuitZoo/CircuitZoo.jl

+```
+
+"""
+


remove empty lines between docstrings and types

Krastanov · 2023-08-24T06:51:23Z

src/CircuitZoo/CircuitZoo.jl

+    (success1 && success2)
+end
+
+struct Purify3to1Left <: AbstractCircuit


and rename similarly to previous

Krastanov · 2023-08-24T06:52:26Z

src/CircuitZoo/CircuitZoo.jl

+    measa
+end
+
+struct StringentHead <: AbstractCircuit


Krastanov · 2023-08-24T06:52:35Z

src/CircuitZoo/CircuitZoo.jl

+    success
+end
+
+struct StringentHeadLeft <: AbstractCircuit


docstring and rename

Krastanov · 2023-08-24T06:52:49Z

src/CircuitZoo/CircuitZoo.jl

+    [coinleft(σˣ, [sacrificedL[1]]), coinleft(σˣ, [sacrificedL[2]])]
+end
+
+struct StringentBody <: AbstractCircuit


Krastanov · 2023-08-24T06:53:00Z

src/CircuitZoo/CircuitZoo.jl

+
+end
+
+struct StringentBodyLeft <: AbstractCircuit


docstring and rename

Krastanov · 2023-08-24T06:53:27Z

src/CircuitZoo/CircuitZoo.jl

+```
+
+"""
+


remove empty line between docstring and type definition

Krastanov · 2023-08-24T06:53:38Z

src/CircuitZoo/CircuitZoo.jl

+    success
+end
+
+struct PurifyExpedient <: AbstractCircuit


Krastanov · 2023-08-24T06:53:53Z

src/CircuitZoo/CircuitZoo.jl

+end
+
+
+struct PurifyStringentLeft <: AbstractCircuit


docstring and rename

Krastanov · 2023-08-24T06:54:11Z

src/CircuitZoo/CircuitZoo.jl

+    [a..., b..., c..., d...]
+end
+
+struct PurifyExpedientLeft <: AbstractCircuit


docstring and rename

Krastanov · 2023-08-24T06:57:14Z

This looks pretty great and it is very close to merging. Could you make the changes I suggested and we can discuss the tests you have implemented at the next in-person meeting?

…es in runtests

Barosandu · 2023-08-25T09:15:52Z

I ve done all the renamings and docstrings @Krastanov , and also added EXPEDIENT testing

Barosandu · 2023-08-25T13:08:04Z

test/test_circuitzoo_purification.jl

+        for i in 1:13
+            initialize!(r[(2*i-1):(2*i)], bell)
+        end
+        @test PurifyStringent()(r[1], r[2], r[3:2:25], r[4:2:26]) == true 


test the observable equals to one

Barosandu · 2023-08-25T13:10:38Z

test/test_circuitzoo_purification.jl

+end
+
+@testset "Stringent - Fidelity - CliffordRepr" begin
+    for rep in [CliffordRepr]


Barosandu · 2023-08-25T13:15:39Z

test/test_circuitzoo_purification.jl

+            initialize!(r[(2*i-1):(2*i)], noisy_pair)
+        end
+        if PurifyStringent()(r[1], r[2], r[3:2:25], r[4:2:26]) == true
+            @test_broken observable(r[1:2], projector(bell)) ≈ 0.0


This is a probabilistic test. It has a small chance of triggering

Barosandu · 2023-08-25T13:16:07Z

test/test_circuitzoo_purification.jl

+end
+
+@testset "Expedient - Fidelity - CliffordRepr" begin
+    for rep in [CliffordRepr]


same as expedient

Barosandu · 2023-08-25T13:17:34Z

test/test_circuitzoo_purification.jl

@@ -35,3 +55,312 @@ const bell = StabilizerState("XX ZZ")
        end
    end
 end
+
+@testset "2to1 - Single Qubit" begin


rename 2to1 Node

Barosandu · 2023-08-25T13:19:16Z

test/test_circuitzoo_purification.jl

+            initialize!(r[1:6], bell⊗bell⊗bell)
+            ma = Purify3to1Node(fixtwice)(r[1], [r[3],r[5]])
+            mb = Purify3to1Node(fixtwice)(r[2], [r[4],r[6]])
+            @test ma == mb


Barosandu · 2023-08-25T13:23:03Z

test/test_circuitzoo_purification.jl

+                apply!(r[target], Dict(:X=>X, :Y=>Y, :Z=>Z)[error])
+
+                if Dict(:X=>:Z, :Y=>:X, :Z=>:Y)[error] == fixtwice
+                    @test Purify3to1(fixtwice)(r[1], r[2], [r[3], r[5]], [r[4], r[6]])==true


create an issue on github about parametrization on 3to1 circuits

Alexandru Ariton added 2 commits August 10, 2023 17:13

Added Testing

a0ef05e

Added Testing for Purify3to1

e025a95

Alexandru Ariton added 5 commits August 13, 2023 13:11

added tests

f870835

Added fidelity tests

632c477

Added fidelity tests fin

a1ef171

added fidelity tests (for real)

061b20d

Finalized Tests

ba3512e

Krastanov reviewed Aug 16, 2023

View reviewed changes

Alexandru Ariton added 3 commits August 19, 2023 17:53

Cosmetics

31139b2

Cosmetics 2

c444ab8

Added single qubit circuits and testing for 2to1 and 3to1

ca7c667

Final touches

3d6eb4b

Krastanov reviewed Aug 24, 2023

View reviewed changes

src/CircuitZoo/CircuitZoo.jl Outdated

```

"""

Copy link

Member

Krastanov Aug 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove empty lines between docstrings and types

Krastanov reviewed Aug 24, 2023

View reviewed changes

src/CircuitZoo/CircuitZoo.jl

measa

end

struct StringentHead <: AbstractCircuit

Copy link

Member

Krastanov Aug 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docstring

Krastanov reviewed Aug 24, 2023

View reviewed changes

src/CircuitZoo/CircuitZoo.jl Outdated

success

end

struct StringentHeadLeft <: AbstractCircuit

Copy link

Member

Krastanov Aug 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docstring and rename

Krastanov reviewed Aug 24, 2023

View reviewed changes

src/CircuitZoo/CircuitZoo.jl Outdated

end

struct StringentBodyLeft <: AbstractCircuit

Copy link

Member

Krastanov Aug 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docstring and rename

Krastanov reviewed Aug 24, 2023

View reviewed changes

src/CircuitZoo/CircuitZoo.jl Outdated

```

"""

Copy link

Member

Krastanov Aug 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove empty line between docstring and type definition

Krastanov reviewed Aug 24, 2023

View reviewed changes

src/CircuitZoo/CircuitZoo.jl

success

end

struct PurifyExpedient <: AbstractCircuit

Copy link

Member

Krastanov Aug 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docstring

Krastanov reviewed Aug 24, 2023

View reviewed changes

src/CircuitZoo/CircuitZoo.jl Outdated

end

struct PurifyStringentLeft <: AbstractCircuit

Copy link

Member

Krastanov Aug 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docstring and rename

Krastanov reviewed Aug 24, 2023

View reviewed changes

Alexandru Ariton added 2 commits August 24, 2023 20:23

Added final (final) touches and docstrings

ed08ebc

Added final (final) touches and docstrings, aaaand decomented the lin…

39a7780

…es in runtests

Barosandu commented Aug 25, 2023

View reviewed changes

Alexandru Ariton added 2 commits August 25, 2023 16:36

Deleted redundand tests and renamed some testsets

82e0b17

FINAL Deleted redundand tests and renamed some testsets

c1e2947

Krastanov merged commit 0f48093 into QuantumSavory:master Aug 25, 2023

Added Testing for 3to1 purification #29

Added Testing for 3to1 purification #29

Conversation

Barosandu commented Aug 10, 2023

codecov bot commented Aug 10, 2023 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Barosandu Aug 23, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Barosandu commented Aug 22, 2023

Krastanov commented Aug 22, 2023

Barosandu commented Aug 23, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Krastanov commented Aug 24, 2023

Barosandu commented Aug 25, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Aug 10, 2023 •

edited

Loading

Barosandu Aug 23, 2023 •

edited

Loading