-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print degenerate singular values warning only during derivation #92
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
This can be tested e.g. using a product state PEPS which will lead to a singular value spectrum
But the reverse pass will warn and fail:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks for getting this done! Fixes #89
Thanks! Now I know about |
As suggested in #89, this PR will implement the degenerate singular value warning such that it is printed only when CTMRG is being differentiated.
This makes sense since degenerate values shouldn't really be problematic in the forward pass but in the reverse pass degenerate singular values will make the SVD adjoint diverge and thereby render the CTMRG gradient useless.