Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default SVD algorithm to SDD and update tests #83

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

pbrehmer
Copy link
Collaborator

This PR will change the default SVD algorithm to TensorKit.SDD since this generally outperforms TensorKit.SVD and is used as the default algorithm in TensorKit (and Base uses gesdd). Since this anyways modifies many tests, I will update the tests such that they all use the updated Defaults to the fullest possible extent.

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/utility/svd.jl 50.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/PEPSKit.jl 100.00% <ø> (ø)
src/algorithms/ctmrg/ctmrg.jl 91.39% <100.00%> (ø)
src/algorithms/ctmrg/gaugefix.jl 94.73% <100.00%> (ø)
src/utility/svd.jl 88.52% <50.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Member

@lkdvos lkdvos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like that we are using more Defaults in the tests and reduce the kwargs, looks great for me!

@pbrehmer pbrehmer merged commit 0084a03 into master Oct 31, 2024
8 of 9 checks passed
@pbrehmer pbrehmer deleted the pb-sdd-default branch October 31, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants