Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add drift term keyword to markov.tauchen. #484

Merged
merged 1 commit into from
May 24, 2019

Conversation

shizejin
Copy link
Member

Try to make markov.tauchen able to handle non-zero drift term in the AR(1) process.

Here discusses the logic of modification made.

@pep8speaks
Copy link

pep8speaks commented May 23, 2019

Hello @shizejin! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-05-23 08:54:28 UTC

@coveralls
Copy link

coveralls commented May 23, 2019

Coverage Status

Coverage increased (+0.007%) to 93.95% when pulling 526a891 on shizejin:add_tauchen_drift_term into 26a66c5 on QuantEcon:master.

@shizejin shizejin force-pushed the add_tauchen_drift_term branch from 979d659 to 526a891 Compare May 23, 2019 08:54
@jstac
Copy link
Contributor

jstac commented May 23, 2019

@shizejin Great work and great analysis.

I was surprised the standard deviation wasn't a bit closer so I tried with m=4 and n=150. It was much better.

(I remember now that the approximation actually gets worse when m gets large.)

@mmcky I approve this PR. I would be glad if we could get this merged and a new version of QE.py released quickly to fix the bug @AnjuJoon found.

@mmcky mmcky merged commit 017d98a into QuantEcon:master May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants