Tests for distributions.py #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oyamad
requested changes
Aug 11, 2017
| def test_init(self): | ||
| assert_allclose(self.n, self.test_obj.n) | ||
| assert_allclose(self.a, self.test_obj.a) | ||
| assert_allclose(self.b, self.test_obj.b) |
There was a problem hiding this comment.
I should have told you this, but for equality between scalars, you can use eq_ from nose.tools:
from nose.tools import eq_
eq_(self.test_obj.n, self.n)| self.b = 1 | ||
| self.test_obj = BetaBinomial(self.n, self.a, self.b) | ||
| for prob in self.test_obj.pdf(): | ||
| assert_allclose(0.1, prob) |
There was a problem hiding this comment.
For this you can use assert_allclose:
assert_allclose(test_obj.pdf(), np.full(n+1, 1/(n+1)))e18d9b2 to
9979467
Compare
9979467 to
4ec9e93
Compare
oyamad
approved these changes
Aug 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tests for distributions.py
Close #301