Allow constructing indices with ndindex[idx] #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think the call syntax is just fine if you are converting a variable. It's a little clearer it's a constructor. The getitem syntax is really only preferable when it reduces typing for tuple and slice literals.
I've primarily only done this in places where the index is a literal (particularly a slice or tuple literal, which is the only place where it matters). In other places, especially in the code, a generic ndindex(idx) is clearer as a constructor than ndindex[idx], so I've left it alone.
6c2e5e7 to
2c00367
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.