-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AUDIT - Left Sidebar Zoom #3
Comments
These are the results of the Zoom Audit, Icon behaviorLeft pane behaviorNotes
Suggestions
|
As I was investigating solutions, I found that the scroll bars in the Running Tab also resize in a way that hides practically all their content at 400% zoom. I'm guessing there's some kind of maximum size for the scroll area, but the text within it resizes without constraints. Note: Stephannie and I have noted we have differing results for 400% zoom. It's probably a combo of Chrome vs. Firefox things and my admittedly older JLab 3.0.3 that I default to for the time being. I need to verify if this is still a problem in newer versions. For records, I found this with a combo of
|
I'm following up on this now that we have a direction for how the whole interface will interact with zoom and reflow. Based on this audit, to improve this area for high zoom we need to
|
I think we've discussed the second point, I think the fix is already in notebook v2... (Or in the demos maybe?) I remember seeing it but I'm not sure when that will be merged into Jupyterlab.
In here you are referring to the tabs that have an icon? I may need to do some research because I think I’ve never seen a collapse menu on a vertical tab, like I’m not sure if we want to collapse everything if it doesn’t fit or if we want to do it depending on the screen size and the objects that fit. Do you have a vision for that? I feel removing the minimum width may bring more problems with the items that are inside the sidebar. |
Point 1Nothing to report yet. This is still in sketches. Point 2
I thought the same. I will go try and find the PR and see what the status is. Thanks for confirming. Point 3For point 3, "Make an overflow/"More"/… collapsing menu for the left side bar tabs" I am thinking of a collapsing behavior like the gif on the main menu collapsible menu PR. While I'd like to refine it a little more, here's my first pass at what that would behave like. Screen.Recording.2022-12-22.at.3.32.08.PM.movIn this case, the tab icon buttons that would be pushed out of the viewport when the page zooms are grouped and replaced by the Point 4
I totally agree. There's so many moving parts that I don't think having no minimum width property would work well. But do you think there's no way to improve the minimum width? One of my initial ideas has been having the minimum width be a percent rather than fixed pixels, though I could see how that might create the same problems with small viewports. I wanted to flag it since adding even one more button to that section will create an overflow (even at 200% zoom). Full disclosure, I'm not aware of any current plans to add to the file browser's top menu. If we don't want to change the current minimum width properties, then this point is probably future-proofing too aggressively and we should drop it for now. |
References
The text was updated successfully, but these errors were encountered: