Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set a11y-light default background to #f2f2f2 (light gray) #56

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Conversation

gabalafou
Copy link
Contributor

@gabalafou gabalafou commented Apr 17, 2024

No description provided.

1. a11y-high-contrast-light
2. a11y-light
@gabalafou gabalafou marked this pull request as draft April 17, 2024 21:57
Copy link

github-actions bot commented Apr 17, 2024

PR Preview Action v1.2.0
🚀 Deployed preview to https://Quansight-Labs.github.io/accessible-pygments/pr-preview/pr-56/
on branch gh-pages at 2024-04-19 02:39 UTC

@gabalafou
Copy link
Contributor Author

@trallard I don't think we can use #f2f2f2 on the high contrast theme because it downgrades the AAAs to AAs.

@gabalafou
Copy link
Contributor Author

Per conversation today, I undid the change to the default background change in the high contrast theme, but left the other one in place

@gabalafou gabalafou marked this pull request as ready for review April 19, 2024 02:39
@gabalafou gabalafou changed the title Set default background to #f2f2f2 (light gray) for two themes Set a11y-light default background to #f2f2f2 (light gray) Apr 19, 2024
@trallard trallard merged commit a2b598c into main Apr 29, 2024
6 checks passed
@trallard trallard deleted the f2f2f2 branch April 29, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants