Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decoupled area mode from command channels. We now validate a user cod… #19

Conversation

digitaldan
Copy link

…e and use it to arm/disarm

Signed-off-by: Dan Cunningham dan@digitaldan.com

…e and use it to arm/disarm

Signed-off-by: Dan Cunningham <dan@digitaldan.com>
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
@digitaldan
Copy link
Author

so with these changes my items file looks like

Number AlarmMode "Alarm [MAP(area-modes.map):%s]" {channel="omnilink:area:1:mode"}
String AlarmModeDisarm {channel="omnilink:area:1:disarm"}
String AlarmModeDay {channel="omnilink:area:1:day"}
String AlarmModeNight {channel="omnilink:area:1:night"}
String AlarmModeAway {channel="omnilink:area:1:away"}
String AlarmModeVacation {channel="omnilink:area:1:vacation"}
String AlarmModeDayInstant {channel="omnilink:area:1:day_instant"}
String AlarmModeNightDelayed {channel="omnilink:area:1:night_delayed"}

To activate a channel you send your 4 digit code. The system will validate it and perform the command. I could also add a generic command channel that would accept something like code:mode ( 1234:0) if needed to make this more convenient for sitemaps.

This relates to issue #9 , @boc-tothefuture thoughts?

@boc-tothefuture
Copy link

Looks good to me - this code right now is not actually doing the differentiation between 'arming' and actual mode, correct? It is just setting up the items/things?

@digitaldan
Copy link
Author

n 'arming' and actual mode, correct?

That's actually already in this branch that the PR is against , if there is any exit delay we set the mode to one of the delayed types.

@digitaldan
Copy link
Author

Code validation is always returning true right now, so I need to fix that

Signed-off-by: Dan Cunningham <dan@digitaldan.com>
@digitaldan
Copy link
Author

This is ready to merge

Signed-off-by: Dan Cunningham <dan@digitaldan.com>
…ow what areas objects are in.

Signed-off-by: Dan Cunningham <dan@digitaldan.com>
@craigham craigham merged commit 1d7273c into QuailAutomation:digitaldan-omnilink-binding-thing-types Jun 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants