Fix group by differential privacy in aggregates #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 16 commits
November 13, 2023 11:07
…rivacy_in_aggregates
…by_differential_privacy_in_aggregates
ngrislain
reviewed
Nov 13, 2023
src/relation/mod.rs
Outdated
| @@ -988,6 +988,11 @@ impl Join { | |||
| Integer::from_interval(0, max) | |||
| } | |||
|
|
|||
| pub fn force_size(mut self, size: Integer) -> Self { | |||
| self.size = size; | |||
There was a problem hiding this comment.
Pas possible.
On ne veut pas forcer quoi que ce soit.
Tu peux ajouter un LIMIT si tu veux exprimer que tu sais que la size est < à une grandeur.
ngrislain
reviewed
Nov 13, 2023
src/differential_privacy/group_by.rs
Outdated
|
|
||
| let join_rel: Relation = Relation::join() | ||
| // we force the size of the relation to be equal to the `self Relation` | ||
| .size(right.size().clone()) |
There was a problem hiding this comment.
Non, impossible, tu peux t'en sortir avec une contrainte UNIQUE, non ?
added 4 commits
November 13, 2023 15:26
ngrislain
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.