Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with rustworkx.visit annotations #1353

Merged
merged 4 commits into from
Jan 14, 2025

Conversation

IvanIsCoding
Copy link
Collaborator

Closes #1352

@IvanIsCoding IvanIsCoding requested a review from mtreinish January 5, 2025 23:04
@coveralls
Copy link

coveralls commented Jan 5, 2025

Pull Request Test Coverage Report for Build 12774418094

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.83%

Totals Coverage Status
Change from base Build 12773634822: 0.0%
Covered Lines: 18384
Relevant Lines: 19184

💛 - Coveralls

@barakatzir
Copy link

Why not combine the visit.pyi into visit.py?

@IvanIsCoding
Copy link
Collaborator Author

Why not combine the visit.pyi into visit.py?

visit.py gets ignored in my experience. There is another issue where someone reported the visit annotations as missing when it was only visit.py.

@mtreinish mtreinish added this pull request to the merge queue Jan 14, 2025
Merged via the queue into Qiskit:main with commit f182dc2 Jan 14, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typing: visit not re-exported and partial/missing annotations
4 participants