-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add immediate_dominators function #1323
Add immediate_dominators function #1323
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting this! It is a welcome addition.
I just left some minor comments but overall this is very close to getting merged and released in 0.16
Note: and Clippy has some gotchas too but those should be easy to fix. Run cargo clippy
or look at the CI failure for the lint output
380cb63
to
0e0030c
Compare
0e0030c
to
6a887c2
Compare
6a887c2
to
e6e89f8
Compare
Thanks for the review! I addressed the comments and rebased the branch. Following the new function's renaming, I edited the PR title and description. |
Pull Request Test Coverage Report for Build 11928735689Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic. This should come out when 0.16 is released 🚀
If I didn't miss it, dominance-related functionality is not yet exposed. Apologies if I missed it.
This patch adds a
rustworkx.immediate_dominators
function that has the same functionality asnetworkx.immediate_dominators
. The core functionality is directly provided by thepetgraph
crate, such that only a thin Python binding was necessary.The tests are directly ported from those in networkx.
An equivalent to
networkx.dominance_frontiers
could be added in a later patch.