Remove support for Python 3.8 #1290
Merged
+65
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 11171426645Details
💛 - Coveralls |
mtreinish
approved these changes
Oct 4, 2024
| @@ -1,9 +1,6 @@ | |||
| queue_rules: | |||
| - name: automerge | |||
| conditions: | |||
| - check-success=python3.8-x64 windows-latest | |||
There was a problem hiding this comment.
I need to push a PR to update this config with GitHub merge queues we don't need this, and we can only use mergify for automated backporting.
There was a problem hiding this comment.
Ditto. I actually quite like the GitHub queues, we could move some more expensive checks to the final merge instead of running them each time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is our yearly Python version maintenance. 3.8 reached EOL. I will add the newly released 3.13 in a separate PR to test the wheel release etc.
I profited to update
black,ruffandmypyas well.mypypasses without any changes, but there were some minor differences withblackandruff.