Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate PauliTable and StabilizerTable #9547

Merged
merged 5 commits into from
Apr 12, 2023

Conversation

ikkoham
Copy link
Contributor

@ikkoham ikkoham commented Feb 8, 2023

Summary

Continue #7245 and #7269

Details and comments

@ikkoham ikkoham added Changelog: Deprecation Include in "Deprecated" section of changelog mod: quantum info Related to the Quantum Info module (States & Operators) labels Feb 8, 2023
@ikkoham ikkoham requested a review from a team as a code owner February 8, 2023 10:02
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

@ikkoham ikkoham added this to the 0.24.0 milestone Feb 8, 2023
@coveralls
Copy link

coveralls commented Feb 8, 2023

Pull Request Test Coverage Report for Build 4675731275

  • 13 of 13 (100.0%) changed or added relevant lines in 3 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 85.418%

Files with Coverage Reduction New Missed Lines %
qiskit/extensions/quantum_initializer/squ.py 2 80.0%
Totals Coverage Status
Change from base Build 4672911381: -0.02%
Covered Lines: 67700
Relevant Lines: 79257

💛 - Coveralls

Copy link
Contributor

@Cryoris Cryoris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments otherwise LGTM 🙂

Copy link
Collaborator

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, please use the new @deprecate_func decorator that landed today instead of @deprecate_function. See #9864 for an example.

It should make things easier for you because it auto-generates most the message :) The only part that needs to be manually worded is additional_msg, where you'll usually want to say something like "Instead, use ``blah blah``."

Copy link
Collaborator

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deprecators look good. Thanks!

Copy link
Member

@jakelishman jakelishman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ikko, after the slog that was #7269, I think we're finally in a position where we can do this safely (in as much as deprecations/removals are ever safe). Thanks for sticking with it.

I'm very encouraged that there's no real modifications to any code other than the deprecated components, including in tests; it's a good vote of confidence that we're not relying on these deprecated classes internally.

@jakelishman jakelishman added this pull request to the merge queue Apr 12, 2023
Merged via the queue into Qiskit:main with commit 58aceb5 Apr 12, 2023
@ikkoham ikkoham deleted the quantum_info/deprecate-paulitable branch April 13, 2023 03:19
giacomoRanieri pushed a commit to giacomoRanieri/qiskit-terra that referenced this pull request Apr 16, 2023
* Deprecate PauliTable and StabilizerTable

* Update qiskit/quantum_info/operators/symplectic/pauli_table.py

Co-authored-by: Julien Gacon <gaconju@gmail.com>

* use deprecate_func instead of deprecate_function

---------

Co-authored-by: Julien Gacon <gaconju@gmail.com>
king-p3nguin pushed a commit to king-p3nguin/qiskit-terra that referenced this pull request May 22, 2023
* Deprecate PauliTable and StabilizerTable

* Update qiskit/quantum_info/operators/symplectic/pauli_table.py

Co-authored-by: Julien Gacon <gaconju@gmail.com>

* use deprecate_func instead of deprecate_function

---------

Co-authored-by: Julien Gacon <gaconju@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Deprecation Include in "Deprecated" section of changelog mod: quantum info Related to the Quantum Info module (States & Operators)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants