-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate PauliTable and StabilizerTable #9547
Deprecate PauliTable and StabilizerTable #9547
Conversation
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 4675731275
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small comments otherwise LGTM 🙂
Co-authored-by: Julien Gacon <gaconju@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, please use the new @deprecate_func
decorator that landed today instead of @deprecate_function
. See #9864 for an example.
It should make things easier for you because it auto-generates most the message :) The only part that needs to be manually worded is additional_msg
, where you'll usually want to say something like "Instead, use ``blah blah``."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deprecators look good. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Ikko, after the slog that was #7269, I think we're finally in a position where we can do this safely (in as much as deprecations/removals are ever safe). Thanks for sticking with it.
I'm very encouraged that there's no real modifications to any code other than the deprecated components, including in tests; it's a good vote of confidence that we're not relying on these deprecated classes internally.
* Deprecate PauliTable and StabilizerTable * Update qiskit/quantum_info/operators/symplectic/pauli_table.py Co-authored-by: Julien Gacon <gaconju@gmail.com> * use deprecate_func instead of deprecate_function --------- Co-authored-by: Julien Gacon <gaconju@gmail.com>
* Deprecate PauliTable and StabilizerTable * Update qiskit/quantum_info/operators/symplectic/pauli_table.py Co-authored-by: Julien Gacon <gaconju@gmail.com> * use deprecate_func instead of deprecate_function --------- Co-authored-by: Julien Gacon <gaconju@gmail.com>
Summary
Continue #7245 and #7269
Details and comments