Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin sphinx-autodoc-typehints #9377

Merged
merged 1 commit into from
Jan 16, 2023

Conversation

jakelishman
Copy link
Member

Summary

The 1.21.0 release appears to have changed the spacing in its outputs, which is causing a bunch of Sphinx/docutils warnings for some of our docstrings.

Details and comments

The 1.21.0 release appears to have changed the spacing in its outputs,
which is causing a bunch of Sphinx/docutils warnings for some of our
docstrings.
@jakelishman jakelishman added type: qa Issues and PRs that relate to testing and code quality stable backport potential The bug might be minimal and/or import enough to be port to stable Changelog: None Do not include in changelog labels Jan 16, 2023
@jakelishman jakelishman requested a review from a team as a code owner January 16, 2023 12:17
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3930281783

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 84.821%

Totals Coverage Status
Change from base Build 3915940895: -0.03%
Covered Lines: 65590
Relevant Lines: 77328

💛 - Coveralls

Copy link
Contributor

@Cryoris Cryoris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the speedy fix!

@mergify mergify bot merged commit 3d8a6e0 into Qiskit:main Jan 16, 2023
@jakelishman jakelishman deleted the pin-sphinx-autodoc-typehints branch January 16, 2023 13:38
mergify bot pushed a commit that referenced this pull request Jan 16, 2023
The 1.21.0 release appears to have changed the spacing in its outputs,
which is causing a bunch of Sphinx/docutils warnings for some of our
docstrings.

(cherry picked from commit 3d8a6e0)

# Conflicts:
#	requirements-dev.txt
mergify bot added a commit that referenced this pull request Jan 16, 2023
* Pin sphinx-autodoc-typehints (#9377)

The 1.21.0 release appears to have changed the spacing in its outputs,
which is causing a bunch of Sphinx/docutils warnings for some of our
docstrings.

(cherry picked from commit 3d8a6e0)

# Conflicts:
#	requirements-dev.txt

* Fix merge conflict

Co-authored-by: Jake Lishman <jake.lishman@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog stable backport potential The bug might be minimal and/or import enough to be port to stable type: qa Issues and PRs that relate to testing and code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants