-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ParameterExpression.is_real
if symengine
is installed
#8456
Conversation
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, this seems reasonable to fix the bug while we wait for symengine. Hopefully they fix it soon and we can remove the extra eval call.
Pull Request Test Coverage Report for Build 2799810266
💛 - Coveralls |
) * Fix is_real on ParameterExpression * typo in reno Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 2bab09c)
Summary
Fixes #8417.
Details and comments
This PR works around a case in symengine where an expression is not identified as real or imaginary if it is multiplied by a constant. This led to the unexpected behavior in Qiskit that e.g.
2 * I
was not being identified as imaginary: