CMake improvements! #468
Merged
CMake improvements! #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Static linking is not the default anymore. * Platform Wheel Tag is now configurable via cmake variable. * Updated documentation * CI config file updated accordingly * Added support for Win64 builds on Visual Studio 2017 * Windows C++ Simulator now links with a prebuilt version of OpenBLAS (64 bits), so there's no need to link against LAPACK anymore * cmake added as a dependency * Restored --static-libgcc flag for static MacOS builds so gcc can create *semi* static executables again. Clang doesn't have static compilation.
|
Just a note to clarify that, since static linking is not the default anymore, this PR fixes #393. |
choosen by the wheel module
|
Wonderful - it's a very neat set of improvements, and also thanks for taking the time to document the flags for contributors! 🎉 |
This was referenced May 16, 2018
Closed
Closed
lia-approves
pushed a commit
to edasgupta/qiskit-terra
that referenced
this pull request
Jul 30, 2019
* CMake improvements: * Static linking is not the default anymore. * Platform Wheel Tag is now configurable via cmake variable. * Updated documentation * CI config file updated accordingly * Added support for Win64 builds on Visual Studio 2017 * Windows C++ Simulator now links with a prebuilt version of OpenBLAS (64 bits), so there's no need to link against LAPACK anymore * cmake added as a dependency * Restored --static-libgcc flag for static MacOS builds so gcc can create *semi* static executables again. Clang doesn't have static compilation. * Remove default WHEEL_TAG value so if not specified, the tag is choosen by the wheel module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenBLAS (64 bits), so there's no need to link against
LAPACK anymore
can create semi static executables again. Clang doesn't have
static compilation.
Description
Motivation and Context
How Has This Been Tested?
As we don't have build tests, I have tested it manually on all the platforms we support:
Win64, Linux64, Darwin.
Screenshots (if appropriate):
Types of changes
Checklist: