remove draw(..., line_length, ...) (deprecated after #3108) #4507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtreinish
previously requested changes
May 28, 2020
There was a problem hiding this comment.
This LGTM the line_length kwarg was deprecated in 0.10 which was released in Oct. 2019 so it's had a full deprecation window and is fine to remove now. But this needs an upgrade release note that documents the removal. After that's added this should be good to merge.
|
Release note in 0011669 |
ajavadia
approved these changes
Jun 18, 2020
faisaldebouni
pushed a commit
to faisaldebouni/qiskit-terra
that referenced
this pull request
Aug 5, 2020
…skit#4507) * remove line_length * release note Co-authored-by: Julien Gacon <jules.gacon@googlemail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #3108 we deprecated
line_lengthparameter indraw. Time to remove it.